fix(nitro): Support nested _platform properties in Nitro 2.11.7+
#17596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| } else if (event?.context && hasCfProperty(event.context)) { | ||
| // legacy support (before Nitro v2.11.7 (PR: https://github.com/nitrojs/nitro/pull/3224)) | ||
| storedTraceData = traceDataMap.get(event.context.cf); | ||
| } |
There was a problem hiding this comment.
Bug: Cloudflare Plugin Trace Data Inconsistency
The Cloudflare plugin's trace data storage and retrieval use different priority orders for identifying the cf object as a WeakMap key. This inconsistency can cause trace data lookups to fail, resulting in missing Sentry tracing meta-tags in the HTML. Also, accessing _platform on an H3Event type may lead to TypeScript compilation errors.
There was a problem hiding this comment.
this is no problem when the same nitro version is used (which is the case on the same server)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Nitro v2.11.7, the platform-specific properties like
cloudlfareandcfare nested under_platform(nitrojs/nitro#3224).The
isEventTypefunction is updated to reflect this change.fixes: #17588