Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 12, 2025

Adds a mechanism following the trace origin naming conventions. Decided to go with handled: true since AFAICT, users always have to provide a fallback (as opposed to react ErrorBoundary where this is optional)

closes #17264

@Lms24 Lms24 requested a review from andreiborza September 12, 2025 08:40
@Lms24 Lms24 self-assigned this Sep 12, 2025
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lms24 Lms24 enabled auto-merge (squash) September 12, 2025 09:26
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,157 - 8,921 +3%
GET With Sentry 1,198 13% 1,256 -5%
GET With Sentry (error only) 5,904 64% 6,142 -4%
POST Baseline 1,175 - 1,198 -2%
POST With Sentry 456 39% 503 -9%
POST With Sentry (error only) 1,015 86% 1,068 -5%
MYSQL Baseline 3,288 - 3,324 -1%
MYSQL With Sentry 382 12% 463 -17%
MYSQL With Sentry (error only) 2,593 79% 2,726 -5%

View base workflow run

@Lms24 Lms24 merged commit cf849ab into develop Sep 12, 2025
116 of 119 checks passed
@Lms24 Lms24 deleted the lms/ref-solid-mechanism branch September 12, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust mechanism in solid SDK
2 participants