Skip to content

fix(browser): Always start navigation as root span #17648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s1gr1d merged 2 commits into from
Sep 15, 2025
Merged

fix(browser): Always start navigation as root span #17648

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b061a23
fix(browser): Always start navigation as root span
s1gr1d Sep 15, 2025
4d3cdab
await pageload
s1gr1d Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
await pageload
  • Loading branch information
@s1gr1d
s1gr1d committed Sep 15, 2025
commit 4d3cdab79b54b799ddeee845acc6e2dc2b99f091
10 changes: 2 additions & 8 deletions ...tion-tests/suites/tracing/browserTracingIntegration/interactions-navigation-click/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import { expect } from '@playwright/test';
import type { Event as SentryEvent } from '@sentry/core';
import { sentryTest } from '../../../../utils/fixtures';
import {
envelopeRequestParser,
getFirstSentryEnvelopeRequest,
shouldSkipTracingTest,
waitForTransactionRequest,
} from '../../../../utils/helpers';
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../utils/helpers';

sentryTest(
'click-triggered navigation should produce a root navigation transaction',
Expand All @@ -18,7 +12,7 @@ sentryTest(
const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);
await getFirstSentryEnvelopeRequest<SentryEvent>(page);
await waitForTransactionRequest(page); // "pageload" root span

const interactionRequestPromise = waitForTransactionRequest(
page,
Expand Down
Loading