Skip to content

Conversation

chargome
Copy link
Member

@chargome chargome commented Sep 24, 2025

Will create follow-up PR that tests a middleware e2e setup

closes #17749

@chargome chargome self-assigned this Sep 24, 2025
Copy link
Contributor

github-actions bot commented Sep 24, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,696 - 8,683 +0%
GET With Sentry 1,401 16% 1,377 +2%
GET With Sentry (error only) 5,983 69% 5,879 +2%
POST Baseline 1,203 - 1,205 -0%
POST With Sentry 528 44% 516 +2%
POST With Sentry (error only) 1,059 88% 1,048 +1%
MYSQL Baseline 3,305 - 3,270 +1%
MYSQL With Sentry 457 14% 464 -2%
MYSQL With Sentry (error only) 2,670 81% 2,676 -0%

View base workflow run

@chargome chargome marked this pull request as ready for review September 25, 2025 13:37
@chargome chargome merged commit 42604ea into develop Sep 25, 2025
188 checks passed
@chargome chargome deleted the cg-rr-fix-handlerequest-type branch September 25, 2025 14:06
@wong2
Copy link
Contributor

wong2 commented Sep 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapSentryHandleRequest type mismatch with React Router middleware
3 participants