test(e2e): Pin [email protected] due to @vercel/nft incompatibility
#17777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
[email protected] due to vercel/nft incompatibility[email protected] due to @vercel/nft incompatibility
andreiborza
approved these changes
Sep 25, 2025
Lms24
added a commit
that referenced
this pull request
Sep 25, 2025
…uilding the Lambda layer (#17780) this is actually a fix but not a user-facing one, therefore, `ref`. Starting with `1.14.3`, `import-in-the-middle` uses both, `import` and `require` statements in its `hook.mjs` file. This caused `@vercel/nft` in its default config to _not_ trace the required `hook.js` file (+ all of its dependencies). This PR enables `mixedModules: true` to trace both, requires and imports. In contrast to #17777, we therefore don't have to override the IITM version and we also don't have to revert this PR.
This was referenced Sep 25, 2025
Lms24
added a commit
that referenced
this pull request
Sep 25, 2025
…nft` incompatibility (#17777)" (#17784) Should be good to revert #17777 since [IITM 1.14.4](https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.14.4) was released
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unblocks our CI which was failing because:
@vercel/nftimport-in-the-middlereceived a bug fix which mixesrequireandimportstatements inhooks.mjs. This was released in1.14.3importandrequirestatements, so therequire'dhooks.jsfile is not added to the subset of modules nft returns (we're working on a minimal reproduction and bug report for nft)As a result, we have to pin IITM to the version before the bugfix (
1.14.2) until either IITM reverts/fixes the fix or NFT releases a fix. The terrible part about this though is that users have to do the same thing for now and there's nothing we can do besides documenting to add an override for IITM.Being a JS developer is fun they said...