Skip to content

test(react): Add parameterized route tests for createHashRouter #17789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 5 commits into from
Oct 23, 2025
Merged

test(react): Add parameterized route tests for createHashRouter #17789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaffb1e
more tests
chargome Sep 25, 2025
2a684f5
format
chargome Sep 25, 2025
cec648e
add test case for deely nested route
s1gr1d Oct 21, 2025
a8ca26c
Merge branch 'develop' into cg-rr-hashrouter-params
s1gr1d Oct 23, 2025
8cd26a2
fix CI errors
s1gr1d Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix CI errors
  • Loading branch information
@s1gr1d
s1gr1d committed Oct 23, 2025
commit 8cd26a2ec2de16f3da56bd3b2ea64c00429212cc
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/react-create-hash-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"react-dom": "18.2.0",
"react-router-dom": "^6.4.1",
"react-scripts": "5.0.1",
"typescript": "~5.0.0"
"typescript": "~4.9.5"
},
"scripts": {
"build": "react-scripts build",
Expand Down
6 changes: 0 additions & 6 deletions dev-packages/e2e-tests/test-applications/react-create-hash-router/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ import {
import Index from './pages/Index';
import User from './pages/User';
import Group from './pages/Group';
import Post from './pages/Post';
import PostFeatured from './pages/PostFeatured';
import PostRelated from './pages/PostRelated';
import PostIndex from './pages/PostIndex';

const replay = Sentry.replayIntegration();

Expand Down Expand Up @@ -84,8 +80,6 @@ const router = sentryCreateHashRouter([
},
]);

console.log(router.routes);

const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);

root.render(<RouterProvider router={router} />);