-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(nuxt): Implement server middleware instrumentation #17796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
e7b0353
to
a8ce604
Compare
mydea
reviewed
Sep 29, 2025
mydea
reviewed
Sep 29, 2025
mydea
reviewed
Sep 29, 2025
mydea
reviewed
Sep 29, 2025
mydea
reviewed
Sep 29, 2025
mydea
reviewed
Sep 29, 2025
mydea
reviewed
Sep 29, 2025
e62e50c
to
2523f18
Compare
s1gr1d
reviewed
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! I like this approach.
2523f18
to
f79850e
Compare
s1gr1d
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces instrumentation for Nuxt middleware, ensuring that all middleware handlers are automatically wrapped with tracing and error reporting functionality. The integration is achieved through build-time transformation.
recap:
middlewareInstrumentationPlugin
) that automatically wraps all detected middleware handlers with Sentry instrumentation during the Nitro build process.wrapMiddlewareHandler
utility, which wraps middleware handlers to start a Sentry span, capture request data, record exceptions, and flush events in serverless environments.Note
Adds build-time wrapping of Nuxt server middleware with Sentry spans and error capture, plus Nuxt 3/4 e2e and unit tests.
wrapMiddlewareHandlerWithSentry
inpackages/nuxt/src/runtime/hooks/wrapMiddlewareHandler.ts
to start spans, set attributes (op, origin, route, method, headers), handle hook arrays (onRequest
,onBeforeResponse
), and capture errors.packages/nuxt/src/vite/middlewareConfig.ts
(server import + Rollup plugin to wrapdefineEventHandler
/eventHandler
).packages/nuxt/src/module.ts
by callingaddMiddlewareImports
andaddMiddlewareInstrumentation
during Nitro init when server config is present.dev-packages/e2e-tests/test-applications/nuxt-{3,4}
) covering span creation, attributes, parent-child relationships, and error propagation across hooks and arrays.packages/nuxt/test/runtime/hooks/wrapMiddlewareHandler.test.ts
.Written by Cursor Bugbot for commit 9a4a1f3. This will update automatically on new commits. Configure here.