Skip to content

feat(nextjs): Attach headers using client hook #17831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 13 commits into from
Oct 2, 2025
Merged

feat(nextjs): Attach headers using client hook #17831

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c11cde7
attach headers in event processor
chargome Sep 30, 2025
adc00a6
un-skip tests
chargome Sep 30, 2025
16745d3
use client hook instead
chargome Sep 30, 2025
1ec0da1
.
chargome Sep 30, 2025
1a3f402
remove headers logic from wrappers
chargome Sep 30, 2025
be665a3
add route handler tests
chargome Sep 30, 2025
d566af5
edge hurts
chargome Sep 30, 2025
3a211de
.
chargome Sep 30, 2025
ab16ac7
remove double check for sendDefaultPii
chargome Oct 1, 2025
00ac5f0
early return
chargome Oct 1, 2025
ee86bf5
lint
chargome Oct 1, 2025
acdb953
.
chargome Oct 1, 2025
d727ee9
removed unused header obj
chargome Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
removed unused header obj
  • Loading branch information
@chargome
chargome committed Oct 1, 2025
commit d727ee9f46ada5908190d44c53d03b154fff6990
3 changes: 0 additions & 3 deletions packages/nextjs/src/common/wrapMiddlewareWithSentry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export function wrapMiddlewareWithSentry<H extends EdgeRouteHandler>(

let spanName: string;
let spanSource: TransactionSource;
const headerAttributes: Record<string, string> = {};

if (req instanceof Request) {
isolationScope.setSDKProcessingMetadata({
Expand All @@ -85,7 +84,6 @@ export function wrapMiddlewareWithSentry<H extends EdgeRouteHandler>(
const rootSpan = getRootSpan(activeSpan);
if (rootSpan) {
setCapturedScopesOnSpan(rootSpan, currentScope, isolationScope);
rootSpan.setAttributes(headerAttributes);
}
}

Expand All @@ -96,7 +94,6 @@ export function wrapMiddlewareWithSentry<H extends EdgeRouteHandler>(
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.nextjs.wrap_middleware',
...headerAttributes,
},
},
() => {
Expand Down