Skip to content

feat(nextjs): Prepare for next 16 bundler default #17868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 13 commits into from
Oct 13, 2025
Merged

feat(nextjs): Prepare for next 16 bundler default #17868

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d209fac
add new bundler detection
chargome Oct 6, 2025
3e8681e
update detection
chargome Oct 6, 2025
2b52582
some more tests
chargome Oct 6, 2025
5fa6b29
update app dir test
chargome Oct 6, 2025
1bc8187
update pages dir canary tests
chargome Oct 6, 2025
2aa3877
add start commands for dev mode
chargome Oct 6, 2025
1d46b0e
use canary 40
chargome Oct 6, 2025
b1e0687
Merge branch 'develop' into cg-next-16-e2e
chargome Oct 8, 2025
a0df026
skip webpack dev tests
chargome Oct 9, 2025
d05629f
test conditions for development-webpack
chargome Oct 9, 2025
9ee2db2
only test prod for webpack
chargome Oct 9, 2025
8abbfa5
Merge branch 'develop' into cg-next-16-e2e
chargome Oct 9, 2025
8256be8
ref isDevMode
chargome Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test conditions for development-webpack
  • Loading branch information
@chargome
chargome committed Oct 9, 2025
commit d05629f8a07e8c385639be308b4e5b55ff3e2e5c
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/client-errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const packageJson = require('../package.json');
test('Sends a client-side exception to Sentry', async ({ page }) => {
const nextjsVersion = packageJson.dependencies.next;
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
const isDevMode = process.env.TEST_ENV.includes('development');
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');

await page.goto('/');

Expand Down
3 changes: 2 additions & 1 deletion ...packages/e2e-tests/test-applications/nextjs-app-dir/tests/devErrorSymbolification.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('should have symbolicated dev errors', async ({ page }) => {
test.skip(!process.env.TEST_ENV.includes('development'), 'should be skipped for non-dev mode');
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');
test.skip(!isDevMode, 'should be skipped for non-dev mode');

await page.goto('/');

Expand Down
5 changes: 3 additions & 2 deletions dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const packageJson = require('../package.json');
test('Sends a pageload transaction', async ({ page }) => {
const nextjsVersion = packageJson.dependencies.next;
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
const isDevMode = process.env.TEST_ENV.includes('development');
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');

const pageloadTransactionEventPromise = waitForTransaction('nextjs-app-dir', transactionEvent => {
return transactionEvent?.contexts?.trace?.op === 'pageload' && transactionEvent?.transaction === '/';
Expand Down Expand Up @@ -78,8 +78,9 @@ test('Should send a transaction for instrumented server actions', async ({ page
test('Should send a wrapped server action as a child of a nextjs transaction', async ({ page }) => {
const nextjsVersion = packageJson.dependencies.next;
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
const isDevMode = !!process.env.TEST_ENV && process.env.TEST_ENV.includes('development');
test.skip(!isNaN(nextjsMajor) && nextjsMajor < 14, 'only applies to nextjs apps >= version 14');
test.skip(process.env.TEST_ENV.includes('development'), 'this magically only works in production');
test.skip(isDevMode, 'this magically only works in production');

const nextjsPostTransactionPromise = waitForTransaction('nextjs-app-dir', async transactionEvent => {
return (
Expand Down
2 changes: 1 addition & 1 deletion ...ckages/e2e-tests/test-applications/nextjs-pages-dir/tests/devErrorSymbolification.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('should have symbolicated dev errors', async ({ page }) => {
test.skip(process.env.TEST_ENV !== 'development', 'should be skipped for non-dev mode');
test.skip(!process.env.TEST_ENV?.includes('development'), 'should be skipped for non-dev mode');

await page.goto('/');

Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/nextjs-pages-dir/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForTransaction } from '@sentry-internal/test-utils';

const packageJson = require('../package.json');

test('Sends a pageload transaction', async ({ page }) => {
const nextjsVersion = packageJson.dependencies.next;
const nextjsMajor = Number(nextjsVersion.split('.')[0]);
const isDevMode = process.env.TEST_ENV === 'development';
const isDevMode = process.env.TEST_ENV?.includes('development');

const pageloadTransactionEventPromise = waitForTransaction('nextjs-pages-dir', transactionEvent => {
return transactionEvent?.contexts?.trace?.op === 'pageload' && transactionEvent?.transaction === '/';
Expand Down