Skip to content

fix(node): Pino child loggers #17934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 22 commits into from
Oct 22, 2025
Merged

fix(node): Pino child loggers #17934

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
60ecb6e
feat(node): Allow selective tracking of `pino` loggers
timfish Oct 14, 2025
abdce67
fix(node): `pino` child loggers
timfish Oct 14, 2025
ad39cb4
Fix logic
timfish Oct 15, 2025
f23891a
Merge branch 'develop' into timfish/fix/pino-child-loggers
timfish Oct 15, 2025
e00cf68
Merge branch 'develop' into timfish/fix/pino-child-loggers
timfish Oct 15, 2025
536df18
Merge remote-tracking branch 'upstream/master' into timfish/fix/pino-…
timfish Oct 15, 2025
32cab77
Merge branch 'timfish/fix/pino-child-loggers' of github.com:getsentry…
timfish Oct 15, 2025
4308b37
docs: Update supported Angular version in README
guillaume-moreau Oct 14, 2025
908e4ec
fix(browser): Ignore React 19.2+ component render measure entries (#1…
Lms24 Oct 15, 2025
318ce67
feat(solid): Add support for TanStack Router Solid (#17735)
thedanchez Oct 15, 2025
715f12f
chore(ci): Update Next.js canary testing (#17939)
chargome Oct 15, 2025
1c4c62b
chore: Bump size limit (#17941)
chargome Oct 15, 2025
eb5a5a8
chore: Add external contributor to CHANGELOG.md (#17940)
HazAT Oct 15, 2025
e53277e
fix(react): Add `POP` guard for long-running `pageload` spans (#17867)
onurtemizkan Oct 15, 2025
d03fc61
fix(tracemetrics): Send boolean for internal replay attribute (#17908)
chargome Oct 15, 2025
6abafe3
meta(changelog): Update changelog for 10.20.0
chargome Oct 15, 2025
1b8de2e
Merge branch 'timfish/fix/pino-child-loggers' of github.com:getsentry…
timfish Oct 15, 2025
8eb3787
Child tests
timfish Oct 15, 2025
fe0a46e
Merge branch 'develop' into timfish/fix/pino-child-loggers
timfish Oct 16, 2025
1bc5b4f
No breaking changes!
timfish Oct 16, 2025
b25e47d
remove duplicate test
timfish Oct 16, 2025
fd0242a
Merge branch 'develop' into timfish/fix/pino-child-loggers
timfish Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix logic
  • Loading branch information
@timfish
timfish committed Oct 15, 2025
commit ad39cb4827f5ec293a0f3a9581460f21a98a3842
2 changes: 1 addition & 1 deletion packages/node-core/src/integrations/pino.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function stripIgnoredFields(result: PinoResult): PinoResult {

const _pinoIntegration = defineIntegration((userOptions: DeepPartial<PinoOptions> = {}) => {
const options: PinoOptions = {
autoInstrument: 'autoInstrument' in userOptions ? !!userOptions.autoInstrument : DEFAULT_OPTIONS.autoInstrument,
autoInstrument: userOptions.autoInstrument === false ? userOptions.autoInstrument : DEFAULT_OPTIONS.autoInstrument,
Copy link
Copy Markdown

@cursor cursor Bot Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Logging Regression and Complex Option Handling

The pinoIntegration's stripIgnoredFields function removes the err field from log attributes, which is a regression that loses debugging information. Additionally, the autoInstrument option's assignment logic is overly complex, obscuring how user-provided true values are handled.

Fix in Cursor Fix in Web

error: { ...DEFAULT_OPTIONS.error, ...userOptions.error },
log: { ...DEFAULT_OPTIONS.log, ...userOptions.log },
};
Expand Down
Loading