Skip to content

feat(nextjs): Support cacheComponents on turbopack #18304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 8 commits into from
Nov 25, 2025
Merged

feat(nextjs): Support cacheComponents on turbopack #18304

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f7fb5c4
add test
chargome Nov 24, 2025
5cf5d09
re-export span api
chargome Nov 24, 2025
aa4ef7a
correctly label optional tests
chargome Nov 24, 2025
4d0ff96
skip webpack tests
chargome Nov 24, 2025
84eeeb3
better tests
chargome Nov 25, 2025
0fe6aa3
better check
chargome Nov 25, 2025
7eca48e
Merge branch 'develop' into cg-next-cachecomponents
chargome Nov 25, 2025
40af06a
.
chargome Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
.
  • Loading branch information
@chargome
chargome committed Nov 25, 2025
commit 40af06af555b8098edf6d685dac4691d02543d9f
4 changes: 2 additions & 2 deletions ...kages/e2e-tests/test-applications/nextjs-16-cacheComponents/tests/cacheComponents.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ test('Should render cached component', async ({ page }) => {
const serverTx = await serverTxPromise;

// we want to skip creating spans in cached environments
expect(serverTx.spans?.filter(span => span.op === 'get.todos').length).toHaveLength(0);
expect(serverTx.spans?.filter(span => span.op === 'get.todos')).toHaveLength(0);
await expect(page.locator('#todos-fetched')).toHaveText('Todos fetched: 5');
});

Expand All @@ -23,6 +23,6 @@ test('Should render suspense component', async ({ page }) => {
const serverTx = await serverTxPromise;

// this will be called several times in development mode, so we need to check for at least one span
expect(serverTx.spans?.filter(span => span.op === 'get.todos').length).toBeGreaterThanOrEqual(1);
expect(serverTx.spans?.filter(span => span.op === 'get.todos').length).toBeGreaterThan(0);
await expect(page.locator('#todos-fetched')).toHaveText('Todos fetched: 5');
});