Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent duplicate Server-Timing header entries in Cloudflare
  • Loading branch information
onurtemizkan authored and Lms24 committed Mar 17, 2026
commit 3fdd1114b76b67af902174aa8e4fde0a687a8273
5 changes: 5 additions & 0 deletions packages/remix/src/server/serverTimingTracePropagation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ export function injectServerTimingHeaderValue(response: Response, serverTimingVa
const headers = new Headers(response.headers);
const existing = headers.get('Server-Timing');

// Avoid duplicate entries when manually injected in entry.server.tsx
if (existing?.includes('sentry-trace')) {
return response;
}

headers.set('Server-Timing', existing ? `${existing}, ${serverTimingValue}` : serverTimingValue);

return new Response(response.body, {
Expand Down
18 changes: 18 additions & 0 deletions packages/remix/test/server/serverTimingTracePropagation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,5 +127,23 @@ describe('serverTimingTracePropagation', () => {

expect(result.headers.get('Server-Timing')).toBe('cache;dur=100, sentry-trace;desc="test"');
});

it('skips injection when sentry-trace already exists in Server-Timing header', () => {
const mockResponse = new Response('test body', {
status: 200,
headers: new Headers({
'Server-Timing': 'sentry-trace;desc="existing-trace", baggage;desc="existing-baggage"',
}),
});

const result = injectServerTimingHeaderValue(
mockResponse,
'sentry-trace;desc="new-trace", baggage;desc="new-baggage"',
);

expect(result.headers.get('Server-Timing')).toBe(
'sentry-trace;desc="existing-trace", baggage;desc="existing-baggage"',
);
});
});
});