Skip to content

ref(core): Streamline and test browserPerformanceTimeOrigin #18708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 6 commits into from
Jan 7, 2026
Merged

ref(core): Streamline and test browserPerformanceTimeOrigin #18708

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0417dd6
ref(core): Streamline and test `browserPerformanceTimeOrigin`
Lms24 Jan 7, 2026
e32955f
add test file
Lms24 Jan 7, 2026
3dca951
fix repeated cache misses when caching `undefined`
Lms24 Jan 7, 2026
3b6d45e
Apply suggestions from code review
Lms24 Jan 7, 2026
faec1fb
Update packages/core/test/lib/utils/time.test.ts
Lms24 Jan 7, 2026
12da3f0
format
Lms24 Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@Lms24
Lms24 authored Jan 7, 2026
commit 3b6d45ef89f689cd4582747b22b9cecf5133ae03
7 changes: 1 addition & 6 deletions packages/core/test/lib/utils/time.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,17 +107,12 @@ describe('browserPerformanceTimeOrigin', () => {
it('caches `undefined` result', async () => {
vi.stubGlobal('performance', undefined);

// Get a fresh module instance
const timeModule = await import(`../../../src/utils/time?update=${Date.now()}`);

// Call browserPerformanceTimeOrigin multiple times
const result1 = timeModule.browserPerformanceTimeOrigin();

// All should be undefined
expect(result1).toBeUndefined();

// Now set performance to a valid object - if caching works, the result should still be undefined
// because the first call should have cached the undefined result

vi.stubGlobal('performance', {
timeOrigin: 1000,
now: () => 100,
Expand Down
Loading