-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(hono): Add base for Sentry Hono middleware (Cloudflare) #18787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
57d1ee1
add base hono sdk
s1gr1d 42b3106
specific request and response handlers
s1gr1d bf3691e
move test files
s1gr1d d8f3188
move middleware
s1gr1d 872d161
update tests
s1gr1d 72c50a5
add hono to verdaccio
s1gr1d d29486b
upgrade versions
s1gr1d 2ea9455
Merge branch 'develop' into sig/hono-package-1-cloudflare
s1gr1d 9f32bb6
add integration tests
s1gr1d c710e05
update wrangler
s1gr1d 3f43971
fix lint error
s1gr1d dc5cfb9
update readme etc.
s1gr1d 43f0e20
Review suggestions
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
move middleware
- Loading branch information
commit d8f31881505fd0110c8c8b469b012b1f894ffda3
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| export { sentry } from './middleware/middleware.cloudflare'; | ||
| export { sentry } from './cloudflare/middleware'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export * from './middleware/middleware.base'; | ||
| // eslint-disable-next-line @typescript-eslint/explicit-function-return-type | ||
| export const sentryNoOp = () => {}; | ||
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: Wouldn't it be better to just not export anything? It feels odd to get a suggestion here that doesn't do anything