Skip to content

fix(profiling): Add platform to envelope item header #18954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s1gr1d merged 2 commits into from
Jan 23, 2026
Merged

fix(profiling): Add platform to envelope item header #18954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2155d95
fix(profiling): Add `platform` to envelope item header
s1gr1d Jan 23, 2026
92696ae
use direct assertion
s1gr1d Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use direct assertion
  • Loading branch information
@s1gr1d
s1gr1d committed Jan 23, 2026
commit 92696ae49869fac0d9ff787d1ac301d5eff63254
6 changes: 3 additions & 3 deletions dev-packages/browser-integration-tests/suites/profiling/manualMode/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
properFullEnvelopeRequestParser,
shouldSkipTracingTest,
} from '../../../utils/helpers';
import { validateProfile, validateProfileItemHeader, validateProfilePayloadMetadata } from '../test-utils';
import { validateProfile, validateProfilePayloadMetadata } from '../test-utils';

sentryTest(
'does not send profile envelope when document-policy is not set',
Expand Down Expand Up @@ -48,7 +48,7 @@ sentryTest('sends profile_chunk envelopes in manual mode', async ({ page, getLoc
const envelopeItemHeader = profileChunkEnvelopeItem[0];
const envelopeItemPayload1 = profileChunkEnvelopeItem[1];

validateProfileItemHeader(envelopeItemHeader);
expect(envelopeItemHeader).toEqual({ type: 'profile_chunk', platform: 'javascript' });
expect(envelopeItemPayload1.profile).toBeDefined();

const profilerId1 = envelopeItemPayload1.profiler_id;
Expand All @@ -71,7 +71,7 @@ sentryTest('sends profile_chunk envelopes in manual mode', async ({ page, getLoc
const envelopeItemHeader2 = profileChunkEnvelopeItem2[0];
const envelopeItemPayload2 = profileChunkEnvelopeItem2[1];

validateProfileItemHeader(envelopeItemHeader2);
expect(envelopeItemHeader2).toEqual({ type: 'profile_chunk', platform: 'javascript' });
expect(envelopeItemPayload2.profile).toBeDefined();

expect(envelopeItemPayload2.profiler_id).toBe(profilerId1); // same profiler id for the whole session
Expand Down
5 changes: 0 additions & 5 deletions dev-packages/browser-integration-tests/suites/profiling/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ interface ValidateProfileOptions {
isChunkFormat?: boolean;
}

export function validateProfileItemHeader(header: Record<string, unknown>): void {
expect(header).toHaveProperty('type', 'profile_chunk');
expect(header).toHaveProperty('platform', 'javascript');
}

/**
* Validates the metadata of a profile chunk envelope.
* https://develop.sentry.dev/sdk/telemetry/profiles/sample-format-v2/
Expand Down
6 changes: 3 additions & 3 deletions ...ges/browser-integration-tests/suites/profiling/traceLifecycleMode_multiple-chunks/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
properFullEnvelopeRequestParser,
shouldSkipTracingTest,
} from '../../../utils/helpers';
import { validateProfile, validateProfileItemHeader, validateProfilePayloadMetadata } from '../test-utils';
import { validateProfile, validateProfilePayloadMetadata } from '../test-utils';

sentryTest(
'does not send profile envelope when document-policy is not set',
Expand Down Expand Up @@ -51,7 +51,7 @@ sentryTest(
const envelopeItemHeader = profileChunkEnvelopeItem[0];
const envelopeItemPayload1 = profileChunkEnvelopeItem[1];

validateProfileItemHeader(envelopeItemHeader);
expect(envelopeItemHeader).toEqual({ type: 'profile_chunk', platform: 'javascript' });
expect(envelopeItemPayload1.profile).toBeDefined();

validateProfilePayloadMetadata(envelopeItemPayload1);
Expand All @@ -77,7 +77,7 @@ sentryTest(
const envelopeItemHeader2 = profileChunkEnvelopeItem2[0];
const envelopeItemPayload2 = profileChunkEnvelopeItem2[1];

validateProfileItemHeader(envelopeItemHeader2);
expect(envelopeItemHeader2).toEqual({ type: 'profile_chunk', platform: 'javascript' });
expect(envelopeItemPayload2.profile).toBeDefined();

validateProfilePayloadMetadata(envelopeItemPayload2);
Expand Down
4 changes: 2 additions & 2 deletions ...s/browser-integration-tests/suites/profiling/traceLifecycleMode_overlapping-spans/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
shouldSkipTracingTest,
waitForTransactionRequestOnUrl,
} from '../../../utils/helpers';
import { validateProfile, validateProfileItemHeader, validateProfilePayloadMetadata } from '../test-utils';
import { validateProfile, validateProfilePayloadMetadata } from '../test-utils';

sentryTest(
'does not send profile envelope when document-policy is not set',
Expand Down Expand Up @@ -52,7 +52,7 @@ sentryTest(
const envelopeItemHeader = profileChunkEnvelopeItem[0];
const envelopeItemPayload = profileChunkEnvelopeItem[1];

validateProfileItemHeader(envelopeItemHeader);
expect(envelopeItemHeader).toEqual({ type: 'profile_chunk', platform: 'javascript' });
expect(envelopeItemPayload.profile).toBeDefined();

validateProfilePayloadMetadata(envelopeItemPayload);
Expand Down
Loading