Skip to content

chore(bugbot): Add rule to flag not-unref'd timers #19082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 2 commits into from
Feb 4, 2026
Merged

chore(bugbot): Add rule to flag not-unref'd timers #19082

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3038eec
chore(bugbor): Add rule to flag not-unref'd timers
Lms24 Jan 29, 2026
a0e3e98
Apply suggestions from code review
Lms24 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
@Lms24
Lms24 authored Jan 29, 2026
commit a0e3e98695ce537aad426212089071f9e8541740
4 changes: 2 additions & 2 deletions .cursor/BUGBOT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,5 @@ Do not flag the issues below if they appear in tests.

## Platform-safe code

- When any `setTimeout` or `setInterval` timers are started in a code path that can end up in server runtime packages (e.g. `@sentry/core` or `@sentry/node`), flag if neither `timeout.unref()` or `safeUnref()` are called.
Not unref'ing a timer can cause CLI or node scripts to run longer than before, due to the process waiting on timers started by the SDK.
- When any `setTimeout` or `setInterval` timers are started in a code path that can end up in server runtime packages (e.g. `@sentry/core` or `@sentry/node`), flag if neither `timeout.unref()` nor `safeUnref()` are called.
Not unref'ing a timer can keep CLI-like applications or node scripts from exiting immediately, due to the process waiting on timers started by the SDK.