-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(nextjs): Add sourcemaps.filesToDeleteAfterUpload as a top-level option
#19280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -284,12 +284,24 @@ export function getBuildPluginOptions({ | |
|
|
||
| const finalIgnorePatterns = mergeIgnorePatterns(sourcemapUploadIgnore, sentryBuildOptions.sourcemaps?.ignore); | ||
|
|
||
| const filesToDeleteAfterUpload = createFilesToDeleteAfterUploadPattern( | ||
| normalizedDistDirAbsPath, | ||
| buildTool, | ||
| deleteSourcemapsAfterUpload, | ||
| useRunAfterProductionCompileHook, | ||
| ); | ||
| const userFilesToDeleteAfterUpload = sentryBuildOptions.sourcemaps?.filesToDeleteAfterUpload; | ||
|
|
||
| if (sentryBuildOptions.debug && userFilesToDeleteAfterUpload !== undefined) { | ||
| // eslint-disable-next-line no-console | ||
| console.debug('[@sentry/nextjs] Skipping auto-deletion of source maps as user has provided filesToDeleteAfterUpload:', userFilesToDeleteAfterUpload); | ||
| } | ||
|
|
||
| const filesToDeleteAfterUpload = | ||
| userFilesToDeleteAfterUpload !== undefined | ||
|
chargome marked this conversation as resolved.
|
||
| ? Array.isArray(userFilesToDeleteAfterUpload) | ||
| ? userFilesToDeleteAfterUpload | ||
| : [userFilesToDeleteAfterUpload] | ||
| : createFilesToDeleteAfterUploadPattern( | ||
| normalizedDistDirAbsPath, | ||
| buildTool, | ||
| deleteSourcemapsAfterUpload, | ||
| useRunAfterProductionCompileHook, | ||
| ); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. User patterns bypass
|
||
|
|
||
| const skipSourcemapsUpload = shouldSkipSourcemapUpload(buildTool, useRunAfterProductionCompileHook); | ||
|
|
||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug log misleadingly implies deletion is skipped entirely
Low Severity
The debug log message says "Skipping auto-deletion of source maps as user has provided filesToDeleteAfterUpload" which implies deletion is being skipped. In reality, the user's custom
filesToDeleteAfterUploadpatterns will be used to delete files — it's only the auto-computed patterns that are skipped. A user debugging withdebug: truecould misinterpret this as "no deletion is happening" when files are indeed being deleted using their custom patterns. The log was specifically requested to help users understand what patterns are being used, but it focuses on what's skipped rather than what's happening.