Skip to content

feat(nestjs): Instrument @nestjs/schedule decorators #19735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 12 commits into from
Mar 11, 2026
Merged

feat(nestjs): Instrument @nestjs/schedule decorators #19735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
573bfe8
feat(nestjs): Instrument @nestjs/schedule
nicohrubec Mar 10, 2026
0908a8d
feat(nestjs): Instrument @nestjs/schedule
nicohrubec Mar 10, 2026
b33344e
updates
nicohrubec Mar 10, 2026
6c8438b
cleanup
nicohrubec Mar 10, 2026
da1d4a7
Do not capture exceptions from sentrycron
nicohrubec Mar 10, 2026
d57b9c4
remove useless unit tests and add changelog
nicohrubec Mar 10, 2026
7d4a5bd
.
nicohrubec Mar 10, 2026
c558682
.
nicohrubec Mar 10, 2026
21ab9a7
fix tests
nicohrubec Mar 10, 2026
15bacc9
update mechanism type and changelog
nicohrubec Mar 11, 2026
6fe21d3
update
nicohrubec Mar 11, 2026
0d33b0f
try to fix lint and support v23
nicohrubec Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@nicohrubec
nicohrubec committed Mar 10, 2026
commit 21ab9a7a3e1d78a40c35f37d75c1c484dce8af8d
8 changes: 6 additions & 2 deletions dev-packages/e2e-tests/test-applications/nestjs-11/tests/cron-decorator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ test('Cron job triggers send of in_progress envelope', async ({ baseURL }) => {

test('Sends exceptions to Sentry on error in cron job', async ({ baseURL }) => {
const errorEventPromise = waitForError('nestjs-11', event => {
return !event.type && event.exception?.values?.[0]?.value === 'Test error from cron job';
return (
!event.type &&
event.exception?.values?.[0]?.value === 'Test error from cron job' &&
event.exception?.values?.[0]?.mechanism?.type === 'auto.schedule.nestjs.cron'
);
});

const errorEvent = await errorEventPromise;
Expand All @@ -73,7 +77,7 @@ test('Sends exceptions to Sentry on error in cron job', async ({ baseURL }) => {
expect(errorEvent.exception?.values?.[0]?.value).toBe('Test error from cron job');
expect(errorEvent.exception?.values?.[0]?.mechanism).toEqual({
handled: false,
type: 'auto.cron.nestjs.async',
type: 'auto.schedule.nestjs.cron',
});

expect(errorEvent.contexts?.trace).toEqual({
Expand Down
8 changes: 6 additions & 2 deletions dev-packages/e2e-tests/test-applications/nestjs-fastify/tests/cron-decorator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ test('Cron job triggers send of in_progress envelope', async ({ baseURL }) => {

test('Sends exceptions to Sentry on error in cron job', async ({ baseURL }) => {
const errorEventPromise = waitForError('nestjs-fastify', event => {
return !event.type && event.exception?.values?.[0]?.value === 'Test error from cron job';
return (
!event.type &&
event.exception?.values?.[0]?.value === 'Test error from cron job' &&
event.exception?.values?.[0]?.mechanism?.type === 'auto.schedule.nestjs.cron'
);
});

const errorEvent = await errorEventPromise;
Expand All @@ -73,7 +77,7 @@ test('Sends exceptions to Sentry on error in cron job', async ({ baseURL }) => {
expect(errorEvent.exception?.values?.[0]?.value).toBe('Test error from cron job');
expect(errorEvent.exception?.values?.[0]?.mechanism).toEqual({
handled: false,
type: 'auto.cron.nestjs.async',
type: 'auto.schedule.nestjs.cron',
Copy link
Copy Markdown
Member

@chargome chargome Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: This would in theory break existing queries – maybe worth calling it out in the changelog

Copy link
Copy Markdown
Member Author

@nicohrubec nicohrubec Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely. I will also update this to auto.function.nestjs.cron (and similar for the others) to align with the span ops

});
expect(errorEvent.contexts?.trace).toEqual({
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
Expand Down
1 change: 0 additions & 1 deletion packages/nestjs/test/integrations/schedule.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,5 @@ describe('ScheduleInstrumentation', () => {

expect(descriptor.value).toBe(originalHandler);
});

});
});
Loading