Skip to content

feat(testing): Always run browser check before BrowserStack tests #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2020
Merged

feat(testing): Always run browser check before BrowserStack tests #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8cf171
always run check
lobsterkatie Feb 21, 2020
29d8a08
fix typo
lobsterkatie Feb 21, 2020
baec6cc
increase timeout
lobsterkatie Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/browser/scripts/checkbrowsers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ const checkLocalConfigsVsBrowserStack = (localConfigs, bsConfigs) => {
}
console.log(
'\nPlease visit https://api.browserstack.com/5/browsers or https://api.browserstack.com/5/browsers?flat=true to choose new configurations.',
"\n\n(If you're sure one of the reported browsers is supported, check to make sure the local config contains all keys (even if they have a null value) and that the values match exactly the ones given by the API.)\n",
);
process.exit(-1);
} else {
console.log('\nAll configurations supported!\n');
}
Expand All @@ -119,9 +121,14 @@ const checkLocalConfigsVsBrowserStack = (localConfigs, bsConfigs) => {
const findUnsupportedConfigs = localConfigs => {
if (!hasCreds()) {
console.warn(
'Unable to find API credentials in env. Please export them as BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY.',
'Unable to find API credentials in env. Please export them as BROWSERSTACK_USERNAME and BROWSERSTACK_ACCESS_KEY.\n',
);
return;
process.exit(-1);
}

if (!localConfigs) {
console.warn('Unable to load local browser configurations.\n');
process.exit(-1);
}

fetchCurrentData(browserstackUsername, browserstackAccessKey)
Expand Down
2 changes: 1 addition & 1 deletion packages/browser/test/integration/suites/loader-specific.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var loaderVariants = [
for (var idx in loaderVariants) {
(function() {
describe(loaderVariants[idx], function() {
this.timeout(5000);
this.timeout(60000);
this.retries(3);

var sandbox;
Expand Down
2 changes: 1 addition & 1 deletion packages/browser/test/integration/suites/shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function runVariant(variant) {
var IS_SYNC_LOADER = !!variant.match(/^loader-lazy-no$/);

describe(variant, function() {
this.timeout(5000);
this.timeout(60000);
this.retries(3);

var sandbox;
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/baseclient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement
originalException: reason as Error,
});
reject(
`Event processing pipeline threw an error, original event will not be sent. Details has been sent as a new event.\nReason: ${reason}`,
`Event processing pipeline threw an error, original event will not be sent. Details have been sent as a new event.\nReason: ${reason}`,
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion scripts/browser-integration.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ yarn
# We have to build other packages first, as we use absolute packages import in TypeScript
yarn build
cd packages/browser
yarn test:integration:checkbrowsers
yarn test:integration
yarn test:package