Skip to content

ref(tracing): Rework tracestate internals to allow for third-party data #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 17, 2021
Merged

ref(tracing): Rework tracestate internals to allow for third-party data #3266

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d955dba
add TransactionMetadata type to @sentry/types
lobsterkatie Feb 17, 2021
f70e334
move method for getting new header from Transaction class to Span class
lobsterkatie Feb 17, 2021
b4e8b8a
store sentry tracestate value in metadata object rather than as top-l…
lobsterkatie Feb 17, 2021
628d33a
let orphan spans get tracestate headers also
lobsterkatie Feb 17, 2021
2124f20
fix envelope headers
lobsterkatie Feb 17, 2021
1df7bfb
clean up tracestate computation function
lobsterkatie Feb 17, 2021
1ee03f3
fix linting issues
lobsterkatie Feb 17, 2021
29a8e02
fix test
lobsterkatie Feb 17, 2021
dd45062
clarify that tracestate.sentry should exist
lobsterkatie Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
let orphan spans get tracestate headers also
  • Loading branch information
@lobsterkatie
lobsterkatie committed Feb 17, 2021
commit 628d33ab516a9d36ba6d487afd21a851349ba1c0
7 changes: 6 additions & 1 deletion packages/tracing/src/span.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,12 @@ export class Span implements SpanInterface {
*/
public getTraceHeaders(): TraceHeaders {
// tracestates live on the transaction, so if this is a free-floating span, there won't be one
const tracestate = this.transaction && `sentry=${this.transaction.metadata?.tracestate?.sentry}`;
let tracestate;
if (this.transaction) {
tracestate = this.transaction.metadata?.tracestate?.sentry;
} else {
tracestate = this._getNewTracestate();
}

return {
'sentry-trace': this.toTraceparent(),
Expand Down