Skip to content

feat(tracing): Handle incoming tracestate data, allow for third-party data #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 27, 2021
Merged

feat(tracing): Handle incoming tracestate data, allow for third-party data #3275

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
da6fccf
standardize naming
lobsterkatie Feb 17, 2021
ae47cea
add method to extract tracestate data from header
lobsterkatie Feb 17, 2021
52f6d98
add thirdparty data to tracestate type
lobsterkatie Feb 22, 2021
ab72f62
more renaming
lobsterkatie Feb 22, 2021
934be68
create toTracestate method
lobsterkatie Feb 22, 2021
91fda65
inherit thidparty tracestate when given
lobsterkatie Feb 22, 2021
269a678
make toTracestate private
lobsterkatie Feb 22, 2021
f6fadf8
add deprecation warning to toTraceparent and alias to private method
lobsterkatie Feb 22, 2021
81c6193
add `tracestate` <meta> tag handling
lobsterkatie Feb 23, 2021
33290ad
read tracestate data from incoming node requests
lobsterkatie Feb 23, 2021
f46c8c4
add todo to span tests
lobsterkatie Feb 23, 2021
06e8d3b
make serverless handle incoming tracestate headers
lobsterkatie Feb 23, 2021
e5cea2e
apply code review fixes
lobsterkatie Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add thirdparty data to tracestate type
  • Loading branch information
@lobsterkatie
lobsterkatie committed Feb 24, 2021
commit 52f6d98aaabcb670127b580a171bc390e305a343
3 changes: 2 additions & 1 deletion packages/types/src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ export enum TransactionSamplingMethod {
export interface TransactionMetadata {
transactionSampling?: { rate?: number; method?: string };

/** The sentry half of a transaction's tracestate header, used for dynamic sampling */
/** The two halves (sentry and third-party) of a transaction's tracestate header, used for dynamic sampling */
tracestate?: {
sentry?: string;
thirdparty?: string;
};
}