Skip to content

chore(tracing): Various small fixes to first tracestate implementation #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2021
Merged

chore(tracing): Various small fixes to first tracestate implementation #3291

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89754e1
clarify comment
lobsterkatie Feb 24, 2021
542d1d1
simplify setting _hub on Transaction instance
lobsterkatie Feb 22, 2021
6361fe4
remove unused hubextensions.traceHeaders
lobsterkatie Feb 22, 2021
b06cecc
make TS happy in http tests
lobsterkatie Feb 24, 2021
782aa47
stop using one-off type
lobsterkatie Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify setting _hub on Transaction instance
  • Loading branch information
@lobsterkatie
lobsterkatie committed Mar 1, 2021
commit 542d1d1aa9d27272c6c9832fbd9f5d165396634e
9 changes: 3 additions & 6 deletions packages/tracing/src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
TransactionContext,
TransactionMetadata,
} from '@sentry/types';
import { dropUndefinedKeys, isInstanceOf, logger } from '@sentry/utils';
import { dropUndefinedKeys, logger } from '@sentry/utils';

import { Span as SpanClass, SpanRecorder } from './span';

Expand All @@ -21,7 +21,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
/**
* The reference to the current hub.
*/
private readonly _hub: Hub = (getCurrentHub() as unknown) as Hub;
private readonly _hub: Hub;

private _trimEnd?: boolean;

Expand All @@ -35,13 +35,10 @@ export class Transaction extends SpanClass implements TransactionInterface {
public constructor(transactionContext: TransactionContext, hub?: Hub) {
super(transactionContext);

if (isInstanceOf(hub, Hub)) {
this._hub = hub as Hub;
}

this.name = transactionContext.name || '';
this.metadata = transactionContext.metadata || {};
this._trimEnd = transactionContext.trimEnd;
this._hub = hub || getCurrentHub();

// create a new sentry tracestate value if we didn't inherit one
if (!this.metadata.tracestate?.sentry) {
Expand Down