Skip to content

Feat: Allow node stackwalk in Electron renderer #3710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Feat: Allow node stackwalk in Electron renderer #3710

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
31935f0
node stackwalk for Electron
timfish Jun 20, 2021
781312e
Merge branch 'master' into feat/node-stackwalk-electron
timfish Jun 21, 2021
f143c10
Re-order params
timfish Jun 21, 2021
c890809
Merge branch 'master' into feat/node-stackwalk-electron
timfish Jun 21, 2021
8b30a9a
Move source loading to seperate file
timfish Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-order params
  • Loading branch information
@timfish
timfish committed Jun 21, 2021
commit f143c1014ef4211b7c626dc7e0dc5523c9e1682b
6 changes: 3 additions & 3 deletions packages/node/src/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ export class NodeBackend extends BaseBackend<NodeOptions> {
* @inheritDoc
*/
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
public eventFromException(exception: any, hint?: EventHint | undefined): PromiseLike<Event> {
return eventFromException(this._options, exception, readFile, hint);
public eventFromException(exception: any, hint?: EventHint): PromiseLike<Event> {
return eventFromException(this._options, exception, hint, readFile);
}

/**
* @inheritDoc
*/
public eventFromMessage(message: string, level: Severity = Severity.Info, hint?: EventHint): PromiseLike<Event> {
return eventFromMessage(this._options, message, level, readFile, hint);
return eventFromMessage(this._options, message, level, hint, readFile);
}

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/node/src/eventbuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ export function eventFromException(
options: NodeOptions,
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
exception: any,
readFile?: ReadFileFn,
hint?: EventHint,
readFile?: ReadFileFn,
): PromiseLike<Event> {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
let ex: any = exception;
Expand Down Expand Up @@ -77,8 +77,8 @@ export function eventFromMessage(
options: NodeOptions,
message: string,
level: Severity = Severity.Info,
readFile?: ReadFileFn,
hint?: EventHint,
readFile?: ReadFileFn,
): PromiseLike<Event> {
const event: Event = {
event_id: hint && hint.event_id,
Expand Down