Skip to content

ref(browser): Split stack line parsers into individual functions and simplify further #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 14, 2022
Merged

ref(browser): Split stack line parsers into individual functions and simplify further #4555

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0ec6249
Refactor tests and minor improvements
timfish Feb 7, 2022
5563471
Remove TraceKitStackFrame
timfish Feb 8, 2022
4db0290
Remove undefined
timfish Feb 8, 2022
8e09b5e
Merge remote-tracking branch 'upstream/master' into remove-tracekitst…
timfish Feb 10, 2022
87c5628
Merge opera parser to slim down code
timfish Feb 10, 2022
245eee9
Lil tidy
timfish Feb 10, 2022
8723236
split into functions
timfish Feb 10, 2022
ee31a1a
More simplify
timfish Feb 11, 2022
6627be7
Minimise fields
timfish Feb 11, 2022
e45decc
Merge remote-tracking branch 'upstream/master' into sep-parsers
timfish Feb 11, 2022
328118b
Re order so we dont break opera!
timfish Feb 11, 2022
3c1e7c2
Move the regex
timfish Feb 11, 2022
98be3a1
Move frame reverse into parser and reverse all test frames 😭
timfish Feb 11, 2022
11a4318
simplify pop
timfish Feb 11, 2022
1c40c42
Couple more simplifications
timfish Feb 11, 2022
24cc5a4
Merge remote-tracking branch 'upstream/master' into sep-parsers
timfish Feb 11, 2022
2bee1b4
Remove useless else
timfish Feb 14, 2022
24a18f3
Move `in_app` to initial declaration
timfish Feb 14, 2022
426828e
Fix bad code
timfish Feb 14, 2022
cb8af0d
Merge remote-tracking branch 'upstream/master' into sep-parsers
timfish Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move the regex
  • Loading branch information
@timfish
timfish committed Feb 11, 2022
commit 3c1e7c28eb67656d18555aa6e1e4826f998b2805
6 changes: 3 additions & 3 deletions packages/browser/src/parsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ export function eventFromError(ex: Error): Event {
};
}

// Based on our own mapping pattern - https://github.com/getsentry/sentry/blob/9f08305e09866c8bd6d0c24f5b0aabdd7dd6c59c/src/sentry/lang/javascript/errormapping.py#L83-L108
const reactMinifiedRegexp = /Minified React error #\d+;/i;

/** Parses stack frames from an error */
export function parseStackFrames(ex: Error & { framesToPop?: number; stacktrace?: string }): StackFrame[] {
// Access and store the stacktrace property before doing ANYTHING
Expand All @@ -101,6 +98,9 @@ export function parseStackFrames(ex: Error & { framesToPop?: number; stacktrace?
return [];
}

// Based on our own mapping pattern - https://github.com/getsentry/sentry/blob/9f08305e09866c8bd6d0c24f5b0aabdd7dd6c59c/src/sentry/lang/javascript/errormapping.py#L83-L108
const reactMinifiedRegexp = /Minified React error #\d+;/i;

function getPopSize(ex: Error & { framesToPop?: number }): number {
if (ex) {
if (typeof ex.framesToPop === 'number') {
Expand Down