Skip to content

ref(browser): Only set event.stacktrace if we have 1 or more frames #4614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2022
Merged

ref(browser): Only set event.stacktrace if we have 1 or more frames #4614

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31ec5b3
Only set event.stacktrace.frames if we actually have a frame
timfish Feb 21, 2022
50977a6
Merge remote-tracking branch 'upstream/master' into event.stacktrace.…
timfish Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Only set event.stacktrace.frames if we actually have a frame
  • Loading branch information
@timfish
timfish committed Feb 21, 2022
commit 31ec5b32bed00794ce7dc0f3981339ed8bcc3e0d
7 changes: 4 additions & 3 deletions packages/browser/src/eventbuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,10 @@ export function eventFromString(
};

if (options.attachStacktrace && syntheticException) {
event.stacktrace = {
frames: parseStackFrames(syntheticException),
};
const frames = parseStackFrames(syntheticException);
if (frames.length) {
event.stacktrace = { frames };
}
}

return event;
Expand Down
7 changes: 4 additions & 3 deletions packages/browser/src/parsers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ export function eventFromPlainObject(
};

if (syntheticException) {
event.stacktrace = {
frames: parseStackFrames(syntheticException),
};
const frames = parseStackFrames(syntheticException);
if (frames.length) {
event.stacktrace = { frames };
}
}

return event;
Expand Down