Skip to content

ref(build): Switch tsconfig target to es6 #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2022
Merged

ref(build): Switch tsconfig target to es6 #5005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5507c13
switch tsconfig `target` to es6
lobsterkatie Apr 28, 2022
604483c
fix node 8 tests
lobsterkatie Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/typescript/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"sourceMap": true,
"strict": true,
"strictBindCallApply": false,
"target": "es5"
"target": "es6"
}
}
8 changes: 8 additions & 0 deletions scripts/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { spawnSync } from 'child_process';
import * as fs from 'fs';
import { join } from 'path';

function run(cmd: string, cwd: string = '') {
Expand Down Expand Up @@ -37,6 +38,7 @@ if (nodeMajorVersion <= 10) {
'@sentry/gatsby',
'@sentry/serverless',
'@sentry/nextjs',
'@sentry/angular',
];

// This is a hack, to deal the fact that the browser-based tests fail under Node 8, because of a conflict buried
Expand All @@ -46,6 +48,12 @@ if (nodeMajorVersion <= 10) {
// against a single version of node, but in the short run, this at least allows us to not be blocked by the
// failures.)
run('rm -rf packages/tracing/test/browser');

// TODO Pull this out once we switch to sucrase builds
// Recompile as es5, so as not to have to fix a compatibility problem that will soon be moot
const baseTSConfig = 'packages/typescript/tsconfig.json';
fs.writeFileSync(baseTSConfig, String(fs.readFileSync(baseTSConfig)).replace('"target": "es6"', '"target": "es5"'));
run(`yarn build:dev ${ignorePackages.map(dep => `--ignore="${dep}"`).join(' ')}`);
}
// Node 10
else {
Expand Down