Skip to content

test(svelte): Add Svelte Testing Library and trackComponent tests #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lforst merged 7 commits into from
Sep 5, 2022
Merged

test(svelte): Add Svelte Testing Library and trackComponent tests #5686

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc90cc4
test(svelte): Add svelte testing library
Lms24 Sep 1, 2022
dd18792
add component tracking test (svelte testing library)
Lms24 Sep 1, 2022
62acf3d
add more trackComponent tests
Lms24 Sep 2, 2022
8e61acf
fix linter errors
Lms24 Sep 2, 2022
3efa16d
fix linter errors again (pls)
Lms24 Sep 2, 2022
30311ef
remove commented code
Lms24 Sep 2, 2022
7b9957f
only run svelte tests on Node >=10
Lms24 Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove commented code
  • Loading branch information
@Lms24
Lms24 committed Sep 2, 2022
commit 30311efe952d964423c4df12df0d32c5a4037fb2
4 changes: 0 additions & 4 deletions packages/svelte/test/components/Dummy.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
export let options;

Sentry.trackComponent(options);

// onMount(() => console.log('>mount'));
// beforeUpdate(() => console.log('>beforeupdate'));
// afterUpdate(() => console.log('>afterupdate'));
</script>

<h1>Hi, I'm a dummy component for testing</h1>
3 changes: 2 additions & 1 deletion packages/svelte/test/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { Scope } from '@sentry/hub';
import { act, render } from '@testing-library/svelte';

// eslint-disable-next-line import/no-unresolved Eslint doesn't know about Svelte components
// linter doesn't like Svelte component imports
// eslint-disable-next-line import/no-unresolved
import DummyComponent from './components/Dummy.svelte';

let returnUndefinedTransaction = false;
Expand Down