Skip to content

fix(tracing): Set sample rate in transaction metadata and DSC #5691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

fix(tracing): Set sample rate in transaction metadata and DSC #5691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04dffa3
fix(tracing): Set sample rate in transaction
Lms24 Sep 2, 2022
7acff3a
fix test
Lms24 Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/tracing/src/hubextensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ function sample<T extends Transaction>(
// if the user has forced a sampling decision by passing a `sampled` value in their transaction context, go with that
if (transaction.sampled !== undefined) {
transaction.setMetadata({
transactionSampling: { method: 'explicitly_set' },
transactionSampling: {
method: 'explicitly_set',
rate: Number(transaction.sampled),
},
});
return transaction;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/tracing/test/hub.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ describe('Hub', () => {
hub.startTransaction({ name: 'dogpark', sampled: true });

expect(Transaction.prototype.setMetadata).toHaveBeenCalledWith({
transactionSampling: { method: 'explicitly_set' },
transactionSampling: { method: 'explicitly_set', rate: 1.0 },
});
});

Expand Down