Skip to content

ref(replay): Avoid using private hub._withClient #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2022
Merged

ref(replay): Avoid using private hub._withClient #6494

merged 3 commits into from
Dec 12, 2022

Conversation

mydea
Copy link
Member

@mydea mydea commented Dec 12, 2022

This is brittle, and can actually be refactored quite easily.
I also used the time to move the event/envelope creation out into dedicated methods, which we'll need to adapt later.

See: #6493

@mydea mydea added the Package: replay Issues related to the Sentry Replay SDK label Dec 12, 2022
@mydea mydea requested review from billyvg and Lms24 December 12, 2022 08:44
@mydea mydea self-assigned this Dec 12, 2022
This was referenced Dec 12, 2022
Merged
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.7 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.03 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.49 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 54.56 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.28 KB (0%)
@sentry/browser - Webpack (minified) 66.33 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.3 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.3 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.68 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.13 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.72 KB (-0.31% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38 KB (+0.3% 🔺)

Lms24
Lms24 approved these changes Dec 12, 2022
View reviewed changes
@mydea mydea force-pushed the fn/replay-avoid-withClient branch 2 times, most recently from 61f2448 to 0f1d091 Compare December 12, 2022 09:42
@mydea mydea force-pushed the fn/replay-avoid-withClient branch from 0f1d091 to c9e24bf Compare December 12, 2022 10:02
@mydea mydea enabled auto-merge (squash) December 12, 2022 10:04
@mydea mydea merged commit 13778da into master Dec 12, 2022
@mydea mydea deleted the fn/replay-avoid-withClient branch December 12, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@mydea mydea

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @Lms24