Skip to content

chore(replay): contributing.md outdated note #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruno-garcia merged 1 commit into from
Jan 18, 2023
Merged

chore(replay): contributing.md outdated note #6832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
replay contributing outdated note
  • Loading branch information
@bruno-garcia
bruno-garcia authored Jan 17, 2023
commit 0bcfb83ff8cfc5415f45ceeb2bfe93c480ec6576
3 changes: 1 addition & 2 deletions packages/replay/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
## Updating the rrweb dependency

When [updating the `rrweb` dependency](https://github.com/getsentry/sentry-javascript/blob/a493aa6a46555b944c8d896a2164bcd8b11caaf5/packages/replay/package.json?plain=1#LL55),
please be aware that in [addition to `@sentry/replay`'s README.md](https://github.com/getsentry/sentry-javascript/blob/a493aa6a46555b944c8d896a2164bcd8b11caaf5/packages/replay/README.md?plain=1#LL204),
Sentry docs also [point to a specific version of `rrweb`](https://github.com/getsentry/sentry-docs/blob/d6adadffc9e468ba777ccc733e69c373181237c9/src/platforms/javascript/common/session-replay/configuration.mdx?plain=1#LL49) that has configuration that needs to be updated.
please be aware that [`@sentry/replay`'s README.md](https://github.com/getsentry/sentry-javascript/blob/a493aa6a46555b944c8d896a2164bcd8b11caaf5/packages/replay/README.md?plain=1#LL204) also needs to be updated.