Skip to content

feat(node-experimental): Update to new Scope APIs #9799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 15 commits into from
Dec 19, 2023
Merged

feat(node-experimental): Update to new Scope APIs #9799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5a0c65f
feat(node-experimental): Update to new Scope APIs
mydea Dec 12, 2023
02495bf
auto set for http
mydea Dec 12, 2023
3e70cf0
fix capture methods
mydea Dec 12, 2023
908c2c2
linting fixes
mydea Dec 12, 2023
680e251
fix linting
mydea Dec 12, 2023
f35a961
WIP better scope type
mydea Dec 13, 2023
817b2ac
fixes to scope & use scope.clone()
mydea Dec 13, 2023
2054d00
fix circular dep checks
mydea Dec 13, 2023
28180f0
fix scope clone
mydea Dec 13, 2023
ef387f6
add more tests & exports
mydea Dec 13, 2023
2606d33
add more tests & fix attachments
mydea Dec 13, 2023
3d18735
Apply suggestions from code review (typos)
mydea Dec 14, 2023
9be6bb4
PR feedback
mydea Dec 18, 2023
40dc544
ref: Update `withIsolationScope` to not pass current scope
mydea Dec 18, 2023
13c7856
shallow clone user
mydea Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add more tests & exports
  • Loading branch information
@mydea
mydea committed Dec 19, 2023
commit ef387f66e5ed3779082f0759cd380c44d02952d5
5 changes: 5 additions & 0 deletions packages/node-experimental/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export {
withIsolationScope,
// eslint-disable-next-line deprecation/deprecation
configureScope,
getCurrentScope,
getGlobalScope,
getIsolationScope,
setIsolationScope,
setCurrentScope,
} from './sdk/api';
export { getCurrentHub, makeMain } from './sdk/hub';
export { Scope } from './sdk/scope';
Expand Down
5 changes: 4 additions & 1 deletion packages/node-experimental/test/helpers/mockSdkInit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@ import type { NodeExperimentalClientOptions } from '../../src/types';

const PUBLIC_DSN = 'https://username@domain/123';

export function mockSdkInit(options?: Partial<NodeExperimentalClientOptions>) {
export function resetGlobals(): void {
GLOBAL_OBJ.__SENTRY__ = {
extensions: {},
hub: undefined,
globalEventProcessors: [],
logger: undefined,
};
}

export function mockSdkInit(options?: Partial<NodeExperimentalClientOptions>) {
resetGlobals();
init({ dsn: PUBLIC_DSN, defaultIntegrations: false, ...options });
}

Expand Down
Loading