Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change android package to not interfere with sentry package prefix
  • Loading branch information
denrase committed Nov 30, 2020
commit a66bfc2b17d9c1cb58ae4d15ef19daf20a9f75bf
2 changes: 1 addition & 1 deletion android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ android {

defaultConfig {
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
applicationId "io.sentry.sentry_mobile"
applicationId "io.sentrymobile.app"
minSdkVersion 18
targetSdkVersion 28
versionCode flutterVersionCode.toInteger()
Expand Down
2 changes: 1 addition & 1 deletion android/app/src/debug/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.sentry.sentry_mobile">
package="io.sentrymobile.app">
<!-- Flutter needs it to communicate with the running application
to allow setting breakpoints, to provide hot reload, etc.
-->
Expand Down
4 changes: 2 additions & 2 deletions android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.sentry.sentry_mobile">
package="io.sentrymobile.app">
<!-- io.flutter.app.FlutterApplication is an android.app.Application that
calls FlutterMain.startInitialization(this); in its onCreate method.
In most cases you can leave this as-is, but you if you want to provide
Expand All @@ -10,7 +10,7 @@

<application
android:name="io.flutter.app.FlutterApplication"
android:label="sentry_mobile"
android:label="io.sentrymobile.app"
android:icon="@mipmap/ic_launcher">
<activity
android:name=".MainActivity"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package io.sentry.sentry_mobile
package io.sentrymobile.app

import androidx.annotation.NonNull
import io.flutter.embedding.android.FlutterActivity
import io.flutter.embedding.engine.FlutterEngine
import io.flutter.plugin.common.MethodChannel
import android.os.AsyncTask
import com.example.sentry_mobile.NativeCrashJava
import io.sentrymobile.app.NativeCrashJava

class MainActivity: FlutterActivity() {
private val CHANNEL = "sentry-mobile.sentry.io/nativeCrash"
private val CHANNEL = "app.sentrymobile.io/nativeCrash"

override fun configureFlutterEngine(@NonNull flutterEngine: FlutterEngine) {
super.configureFlutterEngine(flutterEngine)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.example.sentry_mobile;
package io.sentrymobile.app;
import android.os.AsyncTask;

public class NativeCrashJava {
Expand Down
2 changes: 1 addition & 1 deletion android/app/src/profile/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.sentry.sentry_mobile">
package="io.sentrymobile.app">
<!-- Flutter needs it to communicate with the running application
to allow setting breakpoints, to provide hot reload, etc.
-->
Expand Down
2 changes: 1 addition & 1 deletion ios/Runner/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Flutter

if let controller = window?.rootViewController as? FlutterViewController {
let batteryChannel = FlutterMethodChannel(
name: "sentry-mobile.sentry.io/nativeCrash",
name: "app.sentrymobile.io/nativeCrash",
binaryMessenger: controller.binaryMessenger
)
batteryChannel.setMethodCallHandler {
Expand Down
2 changes: 1 addition & 1 deletion lib/screens/debug/sentry_flutter_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SentryFlutterScreen extends StatefulWidget {
}

class _SentryFlutterScreenState extends State<SentryFlutterScreen> {
static const platform = MethodChannel('sentry-mobile.sentry.io/nativeCrash');
static const platform = MethodChannel('app.sentrymobile.io/nativeCrash');
bool _loading = false;

final _successResultsHandled = {
Expand Down