feat: Access transaction in current scope #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhcarvalho
force-pushed
the
rhcarvalho/scope-get-transaction
branch
2 times, most recently
from
4ba20b8 to
8839f99
Compare
rhcarvalho
commented
Jun 25, 2020
|
Dang, the current implementation runs into a MYPY limitation because the type annotation for property getter and setter is different. https://travis-ci.com/github/getsentry/sentry-python/builds/173008390 |
rhcarvalho
force-pushed
the
rhcarvalho/scope-get-transaction
branch
from
8839f99 to
c2d1797
Compare
Specially when trying to add spans to automatically instrumented transactions, users need access to the current transaction. This gives direct access no matter how deep the code is in the transaction/span tree.
rhcarvalho
force-pushed
the
rhcarvalho/scope-get-transaction
branch
from
c2d1797 to
d4539e1
Compare
untitaker
reviewed
Jun 26, 2020
| # type: (Any) -> None | ||
| # would be type: (Optional[str]) -> None, see https://github.com/python/mypy/issues/3004 | ||
| """When set this forces a specific transaction name to be set.""" | ||
| # XXX: the docstring above is misleading. The implementation of |
There was a problem hiding this comment.
Feel free to fix that behavior in this PR, I don't think anybody would notice even.
untitaker
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specially when trying to add spans to automatically instrumented transactions, users need access to the current transaction.
This gives direct access no matter how deep the code is in the transaction/span tree.
This replicates a similar feature in JS: getsentry/sentry-javascript#2668.