Skip to content

Use appLaunchedInForeground to determine invalid app start data on Android #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 10 commits into from
Oct 9, 2024
Merged

Use appLaunchedInForeground to determine invalid app start data on Android #4146

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2b596fa
Check if appLaunchedInForeground and launch duration for native app s…
antonis Oct 3, 2024
177ed85
Updates changelog
antonis Oct 3, 2024
cc5b409
Merge branch 'main' into antonis/3995-appLaunchedInForeground
antonis Oct 3, 2024
00e48fb
Removes 1 minute check since this is already implemented
antonis Oct 4, 2024
8864ff1
Adds tests for the fetchNativeAppStart function logic
antonis Oct 4, 2024
ee5b85e
Fixes inverted test logic
antonis Oct 4, 2024
6212a23
Guards execution when app is not launched in the foreground
antonis Oct 4, 2024
27bd810
Removes unnecessary line
antonis Oct 8, 2024
94123f4
Merge branch 'main' into antonis/3995-appLaunchedInForeground
antonis Oct 8, 2024
f632e1c
Merge branch 'main' into antonis/3995-appLaunchedInForeground
antonis Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removes 1 minute check since this is already implemented
  • Loading branch information
@antonis
antonis committed Oct 4, 2024
commit 00e48fb841be02283152ceb5df32586d5c0809f3
7 changes: 2 additions & 5 deletions android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
import java.util.Properties;
import java.util.Set;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;

import io.sentry.Breadcrumb;
import io.sentry.DateUtils;
Expand Down Expand Up @@ -381,10 +380,8 @@ public void fetchNativeRelease(Promise promise) {
}

public void fetchNativeAppStart(Promise promise) {
AppStartMetrics appStartMetrics = AppStartMetrics.getInstance();
if (!appStartMetrics.isAppLaunchedInForeground() ||
appStartMetrics.getAppStartTimeSpan().getDurationMs() > TimeUnit.MINUTES.toMillis(1)) {
logger.log(SentryLevel.WARNING, "Invalid app start data: app not launched in foreground or app start took too long (>60s)");
if (!AppStartMetrics.getInstance().isAppLaunchedInForeground()) {
logger.log(SentryLevel.WARNING, "Invalid app start data: app not launched in foreground.");
promise.resolve(null);
}

Expand Down