Skip to content

Refactor and test RNSentryModuleImpl.fetchNativeDeviceContexts #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 3 commits into from
Nov 11, 2024
Merged

Refactor and test RNSentryModuleImpl.fetchNativeDeviceContexts #4253

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98c47cf
Refactor fetchNativeDeviceContexts for testability
antonis Nov 8, 2024
b7ad111
Test fetchNativeDeviceContexts
antonis Nov 8, 2024
ada50fa
Adds new line at the end
antonis Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor fetchNativeDeviceContexts for testability
  • Loading branch information
@antonis
antonis committed Nov 8, 2024
commit 98c47cf223f0c2d512855cbbecd063530c76f273
14 changes: 10 additions & 4 deletions packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,18 +888,24 @@ private String readStringFromFile(File path) throws IOException {

public void fetchNativeDeviceContexts(Promise promise) {
final @NotNull SentryOptions options = HubAdapter.getInstance().getOptions();
final @Nullable Context context = this.getReactApplicationContext().getApplicationContext();
final @Nullable IScope currentScope = InternalSentrySdk.getCurrentScope();
fetchNativeDeviceContexts(promise, options, context, currentScope);
}

protected void fetchNativeDeviceContexts(
Promise promise,
final @NotNull SentryOptions options,
final @Nullable Context context,
final @Nullable IScope currentScope) {
if (!(options instanceof SentryAndroidOptions)) {
promise.resolve(null);
return;
}

final @Nullable Context context = this.getReactApplicationContext().getApplicationContext();
if (context == null) {
promise.resolve(null);
return;
}

final @Nullable IScope currentScope = InternalSentrySdk.getCurrentScope();
if (currentScope != null) {
// Remove react-native breadcrumbs
Iterator<Breadcrumb> breadcrumbsIterator = currentScope.getBreadcrumbs().iterator();
Expand Down