Skip to content

(2.2) feat: Add Feedback Form UI Branding logo #4357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 11 commits into from
Dec 19, 2024
Merged

(2.2) feat: Add Feedback Form UI Branding logo #4357

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6953a3
Adds sentry branding (png logo)
antonis Dec 11, 2024
d22d660
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/3…
antonis Dec 12, 2024
c02d84f
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/3…
antonis Dec 13, 2024
61e4d4d
Use network resource to avoid packaging issues
antonis Dec 13, 2024
fbb402b
Adds test
antonis Dec 13, 2024
bb79879
Add default value in the doc comment
antonis Dec 13, 2024
1350545
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/3…
antonis Dec 13, 2024
727a423
Embeds sentry logo as a base64 encoded png
antonis Dec 16, 2024
449a803
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/3…
antonis Dec 17, 2024
c6dff03
Use smaller image
antonis Dec 18, 2024
b668999
Merge branch 'antonis/3859-newCaptureFeedbackAPI-Form' into antonis/3…
antonis Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use network resource to avoid packaging issues
  • Loading branch information
@antonis
antonis committed Dec 13, 2024
commit 61e4d4daca6b6233c8936fc097601c5e648d5302
Binary file removed packages/core/assets/sentrylogo.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/core/src/js/feedback/FeedbackForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class FeedbackForm extends React.Component<FeedbackFormProps, FeedbackFor
<View style={styles.titleContainer}>
<Text style={styles.title}>{text.formTitle}</Text>
{config.showBranding && (
<Image source={require('../../../assets/sentrylogo.png')} style={styles.sentryLogo} />
<Image source={{uri: 'https://sentry-brand.storage.googleapis.com/sentry-glyph-black.png'}} style={styles.sentryLogo} />
)}
</View>

Expand Down
Loading