Skip to content

Autoinject feedback widget #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 14 commits into from
Jan 29, 2025
Merged

Autoinject feedback widget #4483

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
638377d
Auto-inject feedback form
antonis Jan 23, 2025
db407ce
Temporarily disable sample rotating indicator
antonis Jan 23, 2025
7837b96
Merge branch 'feedback-ui' into antonis/feedback-autoinject
antonis Jan 27, 2025
e9f428d
Revert "Temporarily disable sample rotating indicator"
antonis Jan 27, 2025
011fea7
Wrap Modal in a View
antonis Jan 27, 2025
a4962b9
Handles Android back button
antonis Jan 27, 2025
2d4abb3
Make modal style configurable
antonis Jan 27, 2025
84108f1
Print an error when the modal is not supported
antonis Jan 27, 2025
587c3fc
Add changelog
antonis Jan 27, 2025
f4df57c
Adds tests
antonis Jan 27, 2025
0d466d2
Get major, minor version with deconstruct declaration
antonis Jan 27, 2025
caa075b
Remove if condition
antonis Jan 27, 2025
8071e8d
Prettier
antonis Jan 27, 2025
d8ab914
Fix test import
antonis Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prettier
  • Loading branch information
@antonis
antonis committed Jan 27, 2025
commit 8071e8d3954459cf311f77e4570292a7fc54f08c
1 change: 0 additions & 1 deletion packages/core/src/js/feedback/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { ReactNativeLibraries } from './../utils/rnlibraries';
export function isModalSupported(): boolean {
const { major, minor } = ReactNativeLibraries.ReactNativeVersion?.version || {};
return !(isFabricEnabled() && major === 0 && minor < 71);

}

export const isValidEmail = (email: string): boolean => {
Expand Down
Loading