Skip to content

feat(feedback): Save form state for un-submitted data #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 8 commits into from
Feb 18, 2025
Merged

feat(feedback): Save form state for un-submitted data #4538

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
38a6085
Save form state for unsubmitted data
antonis Feb 14, 2025
9212cb8
Merge branch 'feedback-ui' into antonis/feedback-save-state
antonis Feb 17, 2025
1efb23e
Omit isVisible from state
antonis Feb 17, 2025
59f2f57
Save/clear form state on unmount
antonis Feb 17, 2025
797611f
Pass the missing attachment parameter in the onSubmitSuccess
antonis Feb 17, 2025
e63ee11
Merge branch 'feedback-ui' into antonis/feedback-save-state
antonis Feb 17, 2025
f17106e
Use instance variable for _didSubmitForm
antonis Feb 18, 2025
6e2d6ec
Fixes lint issue
antonis Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Omit isVisible from state
  • Loading branch information
@antonis
antonis committed Feb 17, 2025
commit 1efb23e290f3aeef6977e8e714d1c191a1e8342c
4 changes: 1 addition & 3 deletions packages/core/src/js/feedback/FeedbackWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ export class FeedbackWidget extends React.Component<FeedbackWidgetProps, Feedbac
...defaultConfiguration
}

private static _savedState: FeedbackWidgetState = {
isVisible: false,
private static _savedState: Omit<FeedbackWidgetState, 'isVisible'> = {
name: '',
email: '',
description: '',
Expand Down Expand Up @@ -273,7 +272,6 @@ export class FeedbackWidget extends React.Component<FeedbackWidgetProps, Feedbac

private _clearFormState = (): void => {
FeedbackWidget._savedState = {
isVisible: false,
name: '',
email: '',
description: '',
Expand Down
Loading