Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
38a6085
Save form state for unsubmitted data
antonis Feb 14, 2025
56a113e
Show selected screenshot
antonis Feb 14, 2025
d2dd1f3
Use image uri instead of UInt8Array in onAddScreenshot callback
antonis Feb 14, 2025
9212cb8
Merge branch 'feedback-ui' into antonis/feedback-save-state
antonis Feb 17, 2025
1efb23e
Omit isVisible from state
antonis Feb 17, 2025
59f2f57
Save/clear form state on unmount
antonis Feb 17, 2025
797611f
Pass the missing attachment parameter in the onSubmitSuccess
antonis Feb 17, 2025
dbf8c90
Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…
antonis Feb 17, 2025
91117e3
Merge branch 'antonis/feedback-show-screenshot' into antonis/feedback…
antonis Feb 17, 2025
f14197d
Use only the uri parameter for the onAddScreenshot callback
antonis Feb 17, 2025
e63ee11
Merge branch 'feedback-ui' into antonis/feedback-save-state
antonis Feb 17, 2025
f220540
Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…
antonis Feb 17, 2025
aae3a98
Merge branch 'antonis/feedback-show-screenshot' into antonis/feedback…
antonis Feb 17, 2025
41cb1ca
Handle attachments on the web
antonis Feb 17, 2025
f5c306f
Use window for showing alerts on the web
antonis Feb 17, 2025
42ab16c
Disable keyboard handling on the web
antonis Feb 17, 2025
f17106e
Use instance variable for _didSubmitForm
antonis Feb 18, 2025
f95ed97
Fixed callback function parameter name for clarity
antonis Feb 18, 2025
869f22b
Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…
antonis Feb 18, 2025
6e2d6ec
Fixes lint issue
antonis Feb 18, 2025
082ef57
Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…
antonis Feb 18, 2025
e5a9bcc
Merge branch 'antonis/feedback-show-screenshot' into antonis/feedback…
antonis Feb 18, 2025
4336622
Merge branch 'antonis/feedback-simplify-onaddscreenshot' into antonis…
antonis Feb 18, 2025
28738bf
Use RN_GLOBAL_OBJ for web alert
antonis Feb 18, 2025
01cb31d
Merge branch 'feedback-ui' into antonis/feedback-webfixes
antonis Feb 18, 2025
5713417
misc(feedback): Improve Feedback Sheet interactions
krystofwoldrich Feb 19, 2025
a74f36f
small fixes
krystofwoldrich Feb 19, 2025
2eeaa46
update snapshots
krystofwoldrich Feb 19, 2025
040fd4a
Merge branch 'feedback-ui' into kw-improve-feedback-interactions
antonis Feb 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed callback function parameter name for clarity
Co-authored-by: Krystof Woldrich <[email protected]>
  • Loading branch information
antonis and krystofwoldrich authored Feb 18, 2025
commit f95ed977ddb156f1d2cca527897be2fd8761e7a9
2 changes: 1 addition & 1 deletion packages/core/src/js/feedback/FeedbackWidget.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export interface FeedbackCallbacks {
/**
* Callback when a screenshot is added
*/
onAddScreenshot?: (screenshotAdded: (uri: string) => void) => void;
onAddScreenshot?: (addScreenshot: (uri: string) => void) => void;

/**
* Callback when feedback is successfully submitted
Expand Down
Loading