feat(feedback): Screenshot button error flow#4757
Merged
antonis merged 3 commits intofeedback-ui-2from Apr 17, 2025
Merged
Conversation
Contributor
|
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
This was referenced Apr 16, 2025
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
Android (new) Performance metrics 🚀
|
10 tasks
Contributor
iOS (legacy) Performance metrics 🚀
|
| if (screenshot === 'ErrorCapturingScreenshot') { | ||
| setTimeout(async () => { | ||
| feedbackAlertDialog(text.errorTitle, text.captureScreenshotError); | ||
| }, 100); |
Contributor
There was a problem hiding this comment.
The delay is here to let the widget slide back up, a.k.a just for better visuals?
Contributor
Author
There was a problem hiding this comment.
Yes, and to prevent the alert from hiding below the modal.
krystofwoldrich
approved these changes
Apr 16, 2025
Contributor
krystofwoldrich
left a comment
krystofwoldrich
left a comment
There was a problem hiding this comment.
Thank you, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Based on #4726
📜 Description
Shows an error message when screenshot capture fails
💡 Motivation and Context
See #4714 (comment)
💚 How did you test it?
Manual with screenshotError.patch, CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog