fix(e2e): Fix captureReplay test on iOS Hermes #5495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sed command was failing with 'illegal byte sequence' on macOS when trying to redact sensitive data from all files in maestro-logs, including binary files (like replay videos). Changes: - Add LC_ALL=C environment variable for macOS to handle any byte sequence - Limit sed processing to text files only (.log, .txt, .yml, .yaml, .json) - Add error suppression (2>/dev/null || true) to prevent script failures This fix will allow us to see the actual test failure logs instead of the redaction script masking the real errors.
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
Android (new) Performance metrics 🚀
|
Contributor
iOS (new) Performance metrics 🚀
|
Contributor
iOS (legacy) Performance metrics 🚀
|
The test was failing because: 1. It was using the deprecated _experiments.replaysOnErrorSampleRate option 2. The sentryApi.js script didn't handle missing replay_id gracefully Changes: - Updated E2E test to use replaysOnErrorSampleRate directly (non-deprecated) - Added null check and better error message in sentryApi.js for missing replay_id Fixes the captureReplay test failure on: - Test RN 0.83.0 new hermes ios production no - Test RN 0.83.0 legacy hermes ios production no
This reverts commit 92f8465.
antonis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fix captureReplay test on iOS Hermes
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog