Skip to content

Add explanation for order of actions when adding a new SDK / module #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adinauer wants to merge 4 commits into
base: master
Choose a base branch
from
+14 −0
Open

Add explanation for order of actions when adding a new SDK / module #85

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1d308c
Add explanation for order of actions when adding a new SDK / module
adinauer Oct 14, 2022
5e53320
Update README.md
adinauer Nov 29, 2022
91389ef
Update README.md
adinauer Nov 29, 2022
3d99b08
Update README.md
adinauer Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update README.md
  • Loading branch information
@adinauer
adinauer authored Nov 29, 2022
commit 91389ef41a76477ef280954aac7318abdf882112
11 changes: 5 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,15 @@ on unix platforms.

### Order of actions

1. Create a PR against this repository and have it merged. See steps below.
2. Perform the release of the SDK (see section below for pre-releases).
3. Add the new package(s) to the `.craft.yml` in the SDK repository.
1. update `.craft.yml` config to publish new package to your registry and GH
2. cut the release
3. update craft config to publish to release registry
4. PR to this repository to manually add published new package. See steps below.
Comment on lines +33 to +36
Copy link
Contributor

@marandaneto marandaneto Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct order is:

  1. release without the craft modules (.craft.yml)
  2. add the released version to the release registry manually
  3. add the modules to craft modules (.craft.yml)
  4. enjoy automatic releases

Copy link
Member Author

@adinauer adinauer Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will update later

Copy link
Member Author

@adinauer adinauer Nov 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's work in progress to make this easier / unnecessary. So let's wait with this PR.


### Pre-releases

If you plan to perform a pre-release (e.g. `alpha`, `beta`, `rc` or similar)
you do not need the entries explained below. So the usual order is to first
release the `alpha` or similar, then merge the PR here to add the SDK / module
and then perform the GA release.
you do not need the entries explained below.

### Steps

Expand Down