Skip to content

fix: Disable tracing on unknown platforms #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 3 commits into from
Jul 22, 2024
Merged

fix: Disable tracing on unknown platforms #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af8fb31
disable tracing on unknown platforms
bitsandfoxes Jul 16, 2024
6e502bb
Merge branch 'main' into fix/switch-crash
bitsandfoxes Jul 16, 2024
6d215df
Updated CHANGELOG.md
bitsandfoxes Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

## Fixes

- The SDK no longer causes games to crash out of the box on platforms that have disk access restrictions (i.e. Nintendo Switch) ([#1728](https://github.com/getsentry/sentry-unity/pull/1728))

### Dependencies

- Bump Cocoa SDK from v8.30.1 to v8.31.1 ([#1726](https://github.com/getsentry/sentry-unity/pull/1726))
Expand Down
7 changes: 7 additions & 0 deletions src/Sentry.Unity/ScriptableSentryUnityOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,13 @@ private void HandlePlatformRestrictions(SentryUnityOptions options, IApplication
options.DiagnosticLogger?.LogDebug("Platform support for automatic session tracking is unknown: disabling.");
options.AutoSessionTracking = false;
}

// Requires file access
if (options.TracesSampleRate > 0.0f)
{
options.DiagnosticLogger?.LogDebug("Platform support for tracing is unknown: disabling.");
options.TracesSampleRate = null;
}
}
}

Expand Down