Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
file write disable on unknown platforms
  • Loading branch information
bitsandfoxes committed Sep 26, 2024
commit d692471996fd5e2331ca2a23c47630d28645dba0
9 changes: 2 additions & 7 deletions src/Sentry.Unity/ScriptableSentryUnityOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ private void HandlePlatformRestrictions(SentryUnityOptions options, IApplication
{
if (unityInfo?.IsKnownPlatform() == false)
{
options.DisableFileWrite = true;

// This is only provided on a best-effort basis for other than the explicitly supported platforms.
if (options.BackgroundWorker is null)
{
Expand All @@ -259,13 +261,6 @@ private void HandlePlatformRestrictions(SentryUnityOptions options, IApplication
options.DiagnosticLogger?.LogDebug("Platform support for automatic session tracking is unknown: disabling.");
options.AutoSessionTracking = false;
}

// Requires file access
if (options.TracesSampleRate > 0.0f)
{
options.DiagnosticLogger?.LogDebug("Platform support for tracing is unknown: disabling.");
options.TracesSampleRate = null;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/sentry-dotnet
Submodule sentry-dotnet updated 70 files
+2 −0 .github/actions/environment/action.yml
+24 −1 .github/workflows/build.yml
+2 −2 .github/workflows/codeql-analysis.yml
+1 −1 .github/workflows/device-tests-android.yml
+52 −0 CHANGELOG.md
+2 −2 Directory.Build.props
+1 −1 modules/Ben.Demystifier
+1 −1 modules/sentry-cocoa
+1 −1 modules/sentry-native
+9 −0 samples/Sentry.Samples.AspNetCore.Mvc/Controllers/HomeController.cs
+28 −3 samples/Sentry.Samples.AspNetCore.Mvc/Program.cs
+2 −0 samples/Sentry.Samples.Console.Metrics/Program.cs
+140 −0 src/Sentry.Bindings.Cocoa/ApiDefinitions.cs
+0 −7 src/Sentry.Bindings.Cocoa/PrivateApiDefinitions.cs
+7 −2 src/Sentry.Extensions.Logging/SentryLogger.cs
+6 −0 src/Sentry.NLog/SentryTarget.cs
+6 −1 src/Sentry.Serilog/SentrySink.cs
+2 −0 src/Sentry/BindableSentryOptions.cs
+3 −5 src/Sentry/Extensibility/DisabledHub.cs
+3 −0 src/Sentry/Extensibility/HubAdapter.cs
+2 −0 src/Sentry/FileAttachmentContent.cs
+19 −6 src/Sentry/GlobalSessionManager.cs
+25 −4 src/Sentry/Http/HttpTransportBase.cs
+9 −2 src/Sentry/ISentryJsonSerializable.cs
+0 −1 src/Sentry/Integrations/WinUIUnhandledExceptionIntegration.cs
+2 −1 src/Sentry/Internal/DebugStackTrace.cs
+0 −53 src/Sentry/Internal/FileSystem.cs
+29 −0 src/Sentry/Internal/FileSystemBase.cs
+7 −1 src/Sentry/Internal/Http/CachingTransport.cs
+53 −8 src/Sentry/Internal/Hub.cs
+15 −6 src/Sentry/Internal/IFileSystem.cs
+19 −4 src/Sentry/Internal/InstallationIdHelper.cs
+2 −2 src/Sentry/Internal/Json.cs
+21 −0 src/Sentry/Internal/ReadOnlyFilesystem.cs
+58 −0 src/Sentry/Internal/ReadWriteFileSystem.cs
+17 −1 src/Sentry/Internal/SdkComposer.cs
+3 −0 src/Sentry/Internal/SystemDiagnosticsMetricsListener.cs
+12 −10 src/Sentry/Protocol/Device.cs
+7 −7 src/Sentry/Sentry.csproj
+15 −6 src/Sentry/SentryOptions.cs
+5 −2 src/Sentry/SentrySdk.cs
+1 −0 src/Sentry/buildTransitive/Sentry.targets
+24 −10 test/Sentry.AspNet.Tests/HttpContextExtensionsTests.cs
+7 −0 test/Sentry.DiagnosticSource.IntegrationTests/SqlListenerTests.RecordsEfAsync.DotNet6_0.verified.txt
+7 −0 test/Sentry.DiagnosticSource.IntegrationTests/SqlListenerTests.RecordsEfAsync.DotNet7_0.verified.txt
+7 −0 test/Sentry.DiagnosticSource.IntegrationTests/SqlListenerTests.RecordsEfAsync.DotNet8_0.verified.txt
+7 −0 test/Sentry.DiagnosticSource.IntegrationTests/SqlListenerTests.RecordsEfAsync.Net4_8.verified.txt
+7 −0 test/Sentry.DiagnosticSource.IntegrationTests/SqlListenerTests.RecordsSqlAsync.verified.txt
+7 −0 test/Sentry.EntityFramework.Tests/IntegrationTests.Simple.verified.txt
+16 −123 test/Sentry.Extensions.Logging.Tests/SentryLoggerTests.cs
+1 −3 test/Sentry.Maui.Tests/SentryMauiAppBuilderExtensionsTests.cs
+25 −0 test/Sentry.NLog.Tests/SentryTargetTests.cs
+4 −3 test/Sentry.Profiling.Tests/SamplingTransactionProfilerTests.cs
+19 −9 test/Sentry.Serilog.Tests/SentrySinkTests.cs
+67 −25 test/Sentry.Testing/FakeFileSystem.cs
+4 −10 test/Sentry.Testing/TempDirectory.cs
+9 −0 test/Sentry.Tests/ApiApprovalTests.Run.DotNet6_0.verified.txt
+9 −0 test/Sentry.Tests/ApiApprovalTests.Run.DotNet7_0.verified.txt
+9 −0 test/Sentry.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
+9 −0 test/Sentry.Tests/ApiApprovalTests.Run.Net4_8.verified.txt
+59 −13 test/Sentry.Tests/GlobalSessionManagerTests.cs
+64 −7 test/Sentry.Tests/HubTests.cs
+4 −3 test/Sentry.Tests/Internals/BackgroundWorkerTests.cs
+39 −54 test/Sentry.Tests/Internals/Http/CachingTransportTests.cs
+6 −4 test/Sentry.Tests/Internals/InstallationIdHelperTests.cs
+140 −0 test/Sentry.Tests/Protocol/DeviceTests.cs
+33 −0 test/Sentry.Tests/ReadOnlyFileSystemTests.cs
+104 −0 test/Sentry.Tests/ReadWriteFileSystemTests.cs
+2 −4 test/Sentry.Tests/SentryClientTests.cs
+1 −4 test/Sentry.Tests/SentrySdkTests.cs