chore: Update to .NET SDK 5.5.0
#2093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
commented
Apr 2, 2025
| @@ -210,7 +210,7 @@ public IEnumerator DebugLogException_IsMarkedUnhandled() | |||
| { | |||
| yield return SetupSceneCoroutine("1_BugFarm"); | |||
|
|
|||
| var expectedMechanism = "\"mechanism\":{\"type\":\"Unity.LogException\",\"handled\":false}}]}"; | |||
| var expectedMechanism = "\"mechanism\":{\"type\":\"Unity.LogException\",\"handled\":false"; | |||
There was a problem hiding this comment.
The mechanism now also contains the ,"data":{"HResult":"magicnumber"}. So we're trimming the check because that's not what we're testing here.
Flash0ver
previously approved these changes
Apr 2, 2025
| @@ -81,6 +81,9 @@ public void SetUser(SentryUser? user) | |||
| } | |||
| } | |||
|
|
|||
| public void SetTrace(SentryId traceId, SpanId parentSpanId) | |||
| { } | |||
There was a problem hiding this comment.
note: will be implemented in follow-up
bitsandfoxes
requested review from
bruno-garcia and
vaind
and removed request for
Flash0ver
bruno-garcia
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.