Skip to content

feat(flags): add python onboarding sidebar #80871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michellewzhang merged 7 commits into from
Nov 20, 2024
Merged

feat(flags): add python onboarding sidebar #80871

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dcfd3ab
feat(flags): add python onboarding sidebar
michellewzhang Nov 15, 2024
9dfbc5a
:recycle: disable button if no secret
michellewzhang Nov 15, 2024
d8b3df0
:recycle: rm of link
michellewzhang Nov 19, 2024
6b02c18
:art: some pr comments
michellewzhang Nov 19, 2024
d10811e
:art: rm extra {}
michellewzhang Nov 19, 2024
8f06bcc
Merge remote-tracking branch 'origin/master' into mz/flag-sidebar
michellewzhang Nov 20, 2024
71b70f3
:recycle: last comments
michellewzhang Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
♻️ disable button if no secret
  • Loading branch information
@michellewzhang
michellewzhang committed Nov 15, 2024
commit 9dfbc5a6629127614e04b8e95b9b280ccd8e1ea1
1 change: 1 addition & 0 deletions static/app/components/events/featureFlags/onboardingIntegrationSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import useApi from 'sentry/utils/useApi';
import useOrganization from 'sentry/utils/useOrganization';

function _usePostSecret({

Check failure on line 14 in static/app/components/events/featureFlags/onboardingIntegrationSection.tsx

View workflow job for this annotation

GitHub Actions / self-hosted 

'_usePostSecret' is declared but its value is never read.
orgSlug,
provider,
}: {
Expand Down Expand Up @@ -75,6 +75,7 @@
// postSecret(secret);
setTokenSaved(true);
}}
disabled={secret === ''}
>
{t('Save')}
</Button>
Expand Down
Loading