Skip to content

feat(replay): Filter out style mutations when extracting DOM nodes #83016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat(replay): Filter out style mutations when extracting DOM nodes #83016

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7ae89c
feat(replay): Filter out `style` mutations when extracting DOM nodes
billyvg Jan 7, 2025
da8232f
add some more comments
billyvg Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add some more comments
  • Loading branch information
@billyvg
billyvg committed Jan 7, 2025
commit da8232f057d52449d0004f1d01d82f67bfd8d4ae
3 changes: 3 additions & 0 deletions static/app/utils/replays/hooks/useExtractDomNodes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ export default function useExtractDomNodes({
}): UseQueryResult<Map<ReplayFrame, Extraction>> {
return useQuery({
queryKey: ['getDomNodes', replay],
// Note: we filter out `style` mutations due to perf issues.
// We can do this as long as we only need the HTML and not need to
// visualize the rendered elements
queryFn: () => replay?.getExtractDomNodes({withoutStyles: true}),
enabled: Boolean(replay),
gcTime: Infinity,
Expand Down
Loading