Skip to content

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Mar 4, 2025

It is a very low volume metric, thus, the base line value is useless. I'm expecting that increasing the sampling rate will give us a more accurate picture.

The screenshot shows what I mean by a useless baseline (it stats at nine rather than zero):
image

It is very low volume and the base line value is useless. Hopefully this improves the situation and gives us a more accurate picture.
@armenzg armenzg self-assigned this Mar 4, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 4, 2025
@armenzg armenzg marked this pull request as ready for review March 4, 2025 20:21
@armenzg armenzg requested a review from a team as a code owner March 4, 2025 20:21
@armenzg armenzg requested a review from MichaelSun48 March 4, 2025 20:21
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #86327       +/-   ##
===========================================
+ Coverage   46.68%   87.90%   +41.22%     
===========================================
  Files        9706     9727       +21     
  Lines      550476   552011     +1535     
  Branches    21475    21475               
===========================================
+ Hits       256984   485247   +228263     
+ Misses     293125    66397   -226728     
  Partials      367      367               

@armenzg armenzg enabled auto-merge (squash) March 5, 2025 12:36
@armenzg armenzg merged commit 3750c7a into master Mar 5, 2025
49 checks passed
@armenzg armenzg deleted the increase_sampling/metric/armenzg branch March 5, 2025 13:04
philipphofmann pushed a commit that referenced this pull request Mar 6, 2025
…86327)

It is a very low volume metric, thus, the base line value is useless.
I'm expecting that increasing the sampling rate will give us a more
accurate picture.

The screenshot shows what I mean by a useless baseline (it stats at nine
rather than zero):
<img width="494" alt="image"
src="https://github.com/user-attachments/assets/9560cccb-6100-46a0-ba30-82abf51c1ebd"
/>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants