feat(auto_source_config): Add a few more metrics #86598
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #86598 +/- ##
==========================================
+ Coverage 87.73% 87.86% +0.13%
==========================================
Files 9863 9802 -61
Lines 558910 557037 -1873
Branches 22052 21640 -412
==========================================
- Hits 490363 489460 -903
+ Misses 68117 67206 -911
+ Partials 430 371 -59 |
| def get_trees_for_org(self) -> dict[str, RepoTree]: | ||
| trees = {} | ||
| repositories = self._populate_repositories() | ||
| with metrics.timer("integrations.source_code_management.populate_repositories.duration"): |
There was a problem hiding this comment.
This is the root of all slowdowns. I want to verify it.
| ] | ||
|
|
||
| metrics.incr( | ||
| "integrations.source_code_management.populate_repositories", |
There was a problem hiding this comment.
I want to calculate how often the cache is hit.
|
|
||
| metrics.incr( | ||
| "integrations.source_code_management.populate_trees", | ||
| tags={"cached": use_cache, "integration": self.integration_name}, |
| break | ||
| with metrics.timer( | ||
| f"{METRIC_PREFIX}.generate_code_mappings.duration", tags={"platform": platform} | ||
| ): |
There was a problem hiding this comment.
The change in this section can be more easily viewed by hiding the white spaces:
| integration_id=organization_integration.integration_id, | ||
| with metrics.timer( | ||
| f"{METRIC_PREFIX}.create_configurations.duration", tags={"platform": platform} | ||
| ): |
There was a problem hiding this comment.
Hiding the white spaces will show that only a line is changed into a multi-line.
|
|
||
| metrics.incr( | ||
| "integrations.source_code_management.populate_repositories", | ||
| tags={"cached": use_cache, "integration": self.integration_name}, |
There was a problem hiding this comment.
The cardinality of self.integration_name is pretty low, right? It'll just be the SCM?
| use_cache = False | ||
| if not repositories: | ||
| use_cache = True |
There was a problem hiding this comment.
Is this inverted? If repositories is present didn't we use cache?
There was a problem hiding this comment.
At least one of us is paying attention! 😅 Fixed now
armenzg
changed the title
armenzg
added this to the
Automate Code Mappings & In-App Stack Trace Rules for Java projects milestone
Add the following perf metrics:
Add the following counting metrics: