Remove the source maps wizard for react-native projects #87702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

smeubank wants to merge 12 commits into master from (feat)no-sourcemaps-wizard-for-rn

Contributor

smeubank commented Mar 24, 2025 •

edited

Loading

Description

The source maps wizard is designed for JavaScript projects. it cannot help developers working with react-native

extends the logic to detect if it is a react-native project and remove the wizard on that condition.
update copy in the modal for react-native projects for different states where we could not find the proper files with debugIds or debugIds were not properly injected
added a generated link to the project's uploaded source maps, based on the given debugId
- source maps page empty state to handle telling developers what they should to remedy that
- configre their react-native project and importantly run scripts for iOS and Android builds

Updated the Source Maps Uploaded page:

react-native project empty state directs users to trigger proper builds to upload source maps, and link to docs
react-native project empty search state directs users to check for uploads of iOS and android bundles and links to docs

Screenshots

updated modal:

empty state:

empty search state:


          Remove the source maps wizard for react-native projects

a8299ff

The source maps wizard is designed for JavaScript projects. it cannot help developers working with react-native

This PR extends the logic to detect if it is a react-native project and rmeove the wizard on that condition.

We should improve the modal to better handle projects but that is another issue.

smeubank requested a review from a team as a code owner

March 24, 2025 10:30

smeubank requested review from priscilawebdev and krystofwoldrich

March 24, 2025 10:31

github-actions bot added the Scope: Frontend label

vercel bot deployed to Preview

March 24, 2025 10:34

View deployment

priscilawebdev previously approved these changes

View reviewed changes


          shufflin some text

c32d18d

remove some repetitive text,  add link to RN source maps docs to top. Since it's kinda hidden below.

vercel bot deployed to Preview

March 24, 2025 14:36

View deployment


          Adding a link to the source maps page

ff220f2

next we should add context to that page, especially for the empty state, which is most likely for users in this flow

codecov bot commented Mar 24, 2025 •

edited

Loading

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
10041	1	10040	11

View the top 1 failed test(s) by shortest run time

SourceMapsDebuggerModal renders proper message when active tab is 'release', release has some
    artifact and release name fetching was unsuccessful

Stack Traces | 0.252s run time

TestingLibraryElementError: Unable to find an element with the text: /This stack frame doesn't have a path/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../events/interfaces/sourceMapsDebuggerModal.spec.tsx:75:40)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:526:9)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

vercel bot deployed to Preview

March 24, 2025 22:33

View deployment

priscilawebdev reviewed

View reviewed changes

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated Show resolved Hide resolved

priscilawebdev dismissed their stale review

March 25, 2025 07:06

there are new changes

priscilawebdev reviewed

View reviewed changes

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated Show resolved Hide resolved

smeubank and others added 2 commits

March 25, 2025 10:06


          Update static/app/components/events/interfaces/sourceMapsDebuggerModa…

a4ab15a

…l.tsx

Co-authored-by: Priscila Oliveira <[email protected]>


          Update static/app/components/events/interfaces/sourceMapsDebuggerModa…

253d3f8

…l.tsx

Co-authored-by: Priscila Oliveira <[email protected]>

vercel bot had a problem deploying to Preview

March 25, 2025 09:15

Failure


          empty state: rn source maps

e0f4e5c

added empty state and empty search state, which includes links to react-native source maps docs, and example scripts of what the developers need to do to ensure they're uploading source maps for Android and iOS builds

vercel bot deployed to Preview

March 25, 2025 11:05

View deployment


          update some copy

2e0f370

vercel bot deployed to Preview

March 25, 2025 13:06

View deployment


          Merge branch 'master' into (feat)no-sourcemaps-wizard-for-rn

0f21922

vercel bot deployed to Preview

March 25, 2025 13:14

View deployment


          update the android scripts

b1aa878

vercel bot deployed to Preview

March 27, 2025 09:32

View deployment

priscilawebdev reviewed

View reviewed changes

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx

    
                                  to={

                                    projectSlug

                                      ? `/settings/projects/${projectSlug}/source-maps/?query=${debugId}`

                                      : `/settings/projects/:projectId/source-maps/?query=${debugId}`

Member

priscilawebdev Mar 28, 2025

does this work? I have never written a link this way

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx Outdated Show resolved Hide resolved

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx

Comment on lines +1262 to +1264

    
                        {tct('You did not upload any artifacts with debug IDs yet.', {

                          link: <ExternalLinkWithIcon href={sourceMapsDocLinks.sourcemaps} />,

                        })}

Member

priscilawebdev Mar 28, 2025

same here. Also if we are going to repeat this multiple times, maybe it is worth creating a reusable component

static/app/components/events/interfaces/sourceMapsDebuggerModal.tsx

    
                      {isReactNativeSDK({sdkName: sourceResolutionResults.sdkName}) && (

                        <p>

                          {tct(

                            'Check your [link:source maps uploads] for the missing source maps for debug ID: [debugId]. You should have source maps for both Android and iOS builds.',

Member

priscilawebdev Mar 28, 2025

should we always have Debug IDs capitalized?

static/app/views/settings/projectSourceMaps/sourceMapsList.tsx Outdated Show resolved Hide resolved

static/app/views/settings/projectSourceMaps/sourceMapsList.tsx Outdated Show resolved Hide resolved

Member

priscilawebdev commented Mar 28, 2025 •

edited

Loading

Should we have a panel wrapping the empty state + a doc button as we have in relays? 🤔

smeubank and others added 2 commits

March 28, 2025 11:56


          Update static/app/views/settings/projectSourceMaps/sourceMapsList.tsx

ff90d07

Co-authored-by: Priscila Oliveira <[email protected]>


          Update static/app/views/settings/projectSourceMaps/sourceMapsList.tsx

6f45ba7

Co-authored-by: Priscila Oliveira <[email protected]>


          Update static/app/components/events/interfaces/sourceMapsDebuggerModa…

a9ba34b

…l.tsx

Co-authored-by: Priscila Oliveira <[email protected]>

vercel bot deployed to Preview

March 28, 2025 11:04

View deployment

priscilawebdev mentioned this pull request

feat(source-maps): Do not render source maps wizard if platform is react native #91860

Merged

getsantry bot added the Stale label

Contributor

getsantry bot commented Jun 6, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry bot removed the Stale label

Contributor

getsantry bot commented Jun 29, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry bot added Stale and removed Stale labels

Contributor

krystofwoldrich commented Jul 3, 2025

This is a great improvement of the UX when source maps are missing for RN project,

what is blocking the merge?

Member

priscilawebdev commented Jul 4, 2025

@krystofwoldrich, this has already been implemented (see below), so this PR can likely be closed. However, I didn’t want to close it myself and was waiting for either Steven or the bot to take care of that

Screen.Recording.2025-07-04.at.07.40.30.mov

Contributor

krystofwoldrich commented Jul 4, 2025

@priscilawebdev Thank you, I see.

Contributor Author

smeubank commented Jul 14, 2025

oh i didn't realize those changes were shipped and correct 😅

i can't confirm the accuracy of the RN scrips but i will close

smeubank closed this

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend